DD4hep: SpecPars Processing #25615

ianna · 2019-01-09T16:48:24Z

Parse SpecParSection with PartSelector and Parameter tags
Store them in a registry accessible from an EventSetup
Add an analyzer and a test

cmsbuild · 2019-01-09T16:48:54Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-01-09T16:55:25Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25615/7904

This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25615/7904/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25615/7904/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

cmsbuild · 2019-01-10T13:13:17Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-01-10T13:18:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25615/7922

This PR adds an extra 44KB to repository

cmsbuild · 2019-01-10T13:19:21Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/MuonCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@ptcox this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

ianna · 2019-01-10T14:08:15Z

please test

cmsbuild · 2019-01-10T14:08:41Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32515/console Started: 2019/01/10 15:09

cmsbuild · 2019-01-10T16:42:23Z

+1
Tested at: ec3c579
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25615/32515/summary.html

cmsbuild · 2019-01-10T16:42:29Z

Comparison job queued.

cmsbuild · 2019-01-10T21:36:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25615/7935

This PR adds an extra 44KB to repository

cmsbuild · 2019-01-10T21:37:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32523/console Started: 2019/01/10 22:37

cmsbuild · 2019-01-10T21:37:11Z

Pull request #25615 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

ianna · 2019-01-10T21:37:12Z

please test

cmsbuild · 2019-01-10T23:45:25Z

+1
Tested at: 4020e1b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25615/32523/summary.html

cmsbuild · 2019-01-10T23:45:30Z

Comparison job queued.

cmsbuild · 2019-01-11T01:20:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25615/32523/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3153717
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153512
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

ianna · 2019-01-11T08:03:29Z

+1

cmsbuild · 2019-01-11T08:03:57Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-01-11T09:24:52Z

@ianna if I try the test provided in this PR (and not run in the unit tests) I get

10:23 cmsdev15 1514> cmsRun testDDSpecPars.py
Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 11-Jan-2019 10:23:28.880 CET
DDTestSpecPars::analyze:
PersistencyIO INFO +++ Set Streamer to dd4hep::OpaqueDataBlock
CompactLoader INFO +++ Processing compact file: DetectorDescription/DDCMS/data/cms-2015-muon-geometry.xml with flag (null)
XercesC FATAL +++ FATAL Error at file "", Line 0 Column: 0 Message:unable to open primary document entity '/build/fabiocos/105X/25615/CMSSW_10_5_X_2019-01-10-2300/src/DetectorDescription/DDCMS/test/python/DetectorDescription/DDCMS/data/cms-2015-muon-geometry.xml'
----- Begin Fatal Exception 11-Jan-2019 10:23:29 CET-----------------------
An exception of category 'StdException' occurred while
[0] Processing Event run: 1 lumi: 1 event: 1 stream: 0
[1] Running path 'p'
[2] Calling method for module DDTestSpecPars/'test'
[3] Using EventSetup component DDSpecParRegistryESProducer/'' to make data DDSpecParRegistry/'' in record DDSpecParRegistryRcd
[4] Using EventSetup component DDDetectorESProducer/'' to make data DDDetector/'' in record DetectorDescriptionRcd
Exception Message:
A std::exception was thrown.
Document::root: Invalid handle!
dd4hep: while parsing DetectorDescription/DDCMS/data/cms-2015-muon-geometry.xml
dd4hep: with plugin:DD4hep_CompactLoader
----- End Fatal Exception -------------------------------------------------

ianna · 2019-01-11T16:02:27Z

@fabiocos - it works for me from the src directory:

[src]$ cmsRun DetectorDescription/DDCMS/test/python/testDDSpecPars.py

I'll change the configurations to use FileInPath in the next PR (and also add the test runner script)

ianna · 2019-01-11T16:38:53Z

@fabiocos - this PR #25625 should address the issue.

cvuosalo · 2019-01-11T18:32:23Z

DetectorDescription/DDCMS/plugins/DDDefinitions2Objects.cc

-  string value = e.attr<string>( DD_CMU( value ));
-  bool eval = e.hasAttr( _U( eval )) ? e.attr<bool>( _U( eval )) : false;
+  string value = e.attr<string>(DD_CMU(value));
+  bool eval = e.hasAttr(_U(eval)) ? e.attr<bool>(_U(eval)) : (specParSect.hasAttr(_U(eval)) ? specParSect.attr<bool>(_U(eval)) : false);


This line qualifies for a comment. You are setting variable based upon its own value???

the variable is set based on an "eval" attribute of an element if it's present, or the parent's element attribute.

_U(eval) actually becomes ::dd4hep::xml::Unicode_eval, which is a constant. Giving bool eval the same name as the tag is confusing. I suggest calling it numberTag since it seems to indicate a number when it is true.

it is actually a flag which indicates if a string needs to be evaluated. The naming is done on purpose and is consistent throughout.

fabiocos · 2019-01-13T21:48:04Z

+1

SpecPars processing

c065504

cmsbuild added this to the CMSSW_10_5_X milestone Jan 9, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Jan 9, 2019

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 9, 2019

Fix from code checker

ec3c579

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 10, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 10, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 10, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 10, 2019

resolve string values in a Parameter

8d71a6b

cmsbuild removed the code-checks-approved label Jan 10, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 10, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 10, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 10, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jan 11, 2019

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Jan 11, 2019

ianna mentioned this pull request Jan 11, 2019

DD4hep: Use Threading Building Blocks #25625

Merged

cvuosalo reviewed Jan 11, 2019

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Jan 13, 2019

cmsbuild merged commit d2e26f0 into cms-sw:master Jan 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DD4hep: SpecPars Processing #25615

DD4hep: SpecPars Processing #25615

ianna commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

ianna commented Jan 10, 2019

cmsbuild commented Jan 10, 2019 •

edited

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019 •

edited

cmsbuild commented Jan 10, 2019

ianna commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 11, 2019

ianna commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

fabiocos commented Jan 11, 2019

ianna commented Jan 11, 2019

ianna commented Jan 11, 2019

cvuosalo Jan 11, 2019

ianna Jan 11, 2019

cvuosalo Jan 12, 2019

ianna Jan 12, 2019

fabiocos commented Jan 13, 2019

DD4hep: SpecPars Processing #25615

DD4hep: SpecPars Processing #25615

Conversation

ianna commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

ianna commented Jan 10, 2019

cmsbuild commented Jan 10, 2019 • edited

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019 • edited

cmsbuild commented Jan 10, 2019

ianna commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 11, 2019

ianna commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

fabiocos commented Jan 11, 2019

ianna commented Jan 11, 2019

ianna commented Jan 11, 2019

cvuosalo Jan 11, 2019

Choose a reason for hiding this comment

ianna Jan 11, 2019

Choose a reason for hiding this comment

cvuosalo Jan 12, 2019

Choose a reason for hiding this comment

ianna Jan 12, 2019

Choose a reason for hiding this comment

fabiocos commented Jan 13, 2019

cmsbuild commented Jan 10, 2019 •

edited

cmsbuild commented Jan 10, 2019 •

edited