New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo to resolve uninitialized value use in pyquen.F #25619
fix typo to resolve uninitialized value use in pyquen.F #25619
Conversation
@cmsbuild please test |
The code-checks are being triggered in jenkins. |
@mandrenguyen |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25619/7918
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages: GeneratorInterface/PyquenInterface @alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The code runs without problem. Tested locally at /afs/cern.ch/work/a/asanchez/public/CMSSW_10_5_X_2019-01-15-1100/src/pyquen.root |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
this was found in a follow up to uninit value use in valgrind run of wf 150.0.
Without the fix, there are multiple instances of uninitialized values both in
HYINIT
and inHYEVNT
.The fix correctly assigns a result from the function grid values when the coordinate is exactly on a grid point.