New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to RPCSimSetup #2562
Fix to RPCSimSetup #2562
Conversation
Signed-off-by: Salvatore Di Guida <salvatore.di.guida@cern.ch>
…om detids not in the loaded RPC geometry
A new Pull Request was created by @pietverwilligen for CMSSW_6_2_X_SLHC. Fix to RPCSimSetup It involves the following packages: Configuration/AlCa @civanch, @diguida, @mdhildreth, @cmsbuild, @nclopezo, @rcastello, @Degano can you please review it and eventually sign? Thanks. |
@@ -47,7 +47,7 @@ | |||
|
|||
void RPCSimSetUp::setRPCSetUp(const std::vector<RPCStripNoises::NoiseItem>& vnoise, const std::vector<float>& vcls){ | |||
|
|||
// std::cout<<"RPCSimSetup :: setRPCSetUp(RPCStripNoises::NoiseItem, float)"<<std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pietverwilligen please convert the std::cout
into edm::LogDebug
(requires re-compilation with flags to activate) edm::LogInfo
, edm::LogWarning
or edm::LogError
according to the severity of the message and the pattern in the code.
Pull request #2562 was updated. @civanch, @diguida, @mdhildreth, @cmsbuild, @nclopezo, @rcastello, @Degano can you please check and sign again. |
merge GEM test; extended pixel test; 3300, 3400, 4100, 4400, 40001, 50002, 60002, 60001, 4502, 4500, 5001, 15001 and 50001 all pass. The GlobalTag for the tests will be checked/changed as part of the expansion for other scenarios. |
upgrades py2-scipy to 0.18.1
Fix to RPCSimSetup
RPCSimSetup crashed when geometries were loaded with less DetIds than provided by the conditions file. Now protection has been built in such that these conditions are ignored.
This fix will allow #2518 to work in all tests performed by RunTheMatrix.