Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to RPCSimSetup #2562

Merged
merged 4 commits into from Feb 21, 2014
Merged

Conversation

pietverwilligen
Copy link
Contributor

Fix to RPCSimSetup

RPCSimSetup crashed when geometries were loaded with less DetIds than provided by the conditions file. Now protection has been built in such that these conditions are ignored.

This fix will allow #2518 to work in all tests performed by RunTheMatrix.

Salvatore Di Guida and others added 3 commits February 18, 2014 19:25
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pietverwilligen for CMSSW_6_2_X_SLHC.

Fix to RPCSimSetup

It involves the following packages:

Configuration/AlCa
SimMuon/RPCDigitizer

@civanch, @diguida, @mdhildreth, @cmsbuild, @nclopezo, @rcastello, @Degano can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@@ -47,7 +47,7 @@

void RPCSimSetUp::setRPCSetUp(const std::vector<RPCStripNoises::NoiseItem>& vnoise, const std::vector<float>& vcls){

// std::cout<<"RPCSimSetup :: setRPCSetUp(RPCStripNoises::NoiseItem, float)"<<std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pietverwilligen please convert the std::cout into edm::LogDebug (requires re-compilation with flags to activate) edm::LogInfo, edm::LogWarning or edm::LogError according to the severity of the message and the pattern in the code.

@cmsbuild
Copy link
Contributor

Pull request #2562 was updated. @civanch, @diguida, @mdhildreth, @cmsbuild, @nclopezo, @rcastello, @Degano can you please check and sign again.

@mark-grimes
Copy link

merge

GEM test; extended pixel test; 3300, 3400, 4100, 4400, 40001, 50002, 60002, 60001, 4502, 4500, 5001, 15001 and 50001 all pass. The GlobalTag for the tests will be checked/changed as part of the expansion for other scenarios.

cmsbuild added a commit that referenced this pull request Feb 21, 2014
@cmsbuild cmsbuild merged commit d45104c into cms-sw:CMSSW_6_2_X_SLHC Feb 21, 2014
@pietverwilligen pietverwilligen deleted the RPSSimSetupFix branch October 21, 2014 10:40
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants