Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precedence order fix in FormulaEvaluator #25622

Merged
merged 3 commits into from Jan 14, 2019
Merged

Precedence order fix in FormulaEvaluator #25622

merged 3 commits into from Jan 14, 2019

Conversation

Dr15Jones
Copy link
Contributor

This fixes a precedence order evaluation problem seen in another pull request.

@Dr15Jones
FormulaEvaluator now ignores white space
8fb1fe7
@Dr15Jones
Fix precedence order bug in FormulaEvaluator
3176168 
-The power operator was incorrectly assigned the precedence order
 the same as '*' and '/'
-This uncovered precedence order problems with the node parsing.
@Dr15Jones
Added runFormulaEvaluator
22e8816 
Created a simple binary which takes as input text to be run via
the FormulaEvaluator.
@cmsbuild cmsbuild added this to the CMSSW_10_5_X milestone Jan 10, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Dr15Jones Dr15Jones mentioned this pull request Jan 10, 2019
Closed
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25622/7934

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CommonTools/Utils

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32522/console Started: 2019/01/10 20:50

@Dr15Jones Dr15Jones mentioned this pull request Jan 10, 2019
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: 22e8816
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25622/32522/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25622/32522/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153512
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jan 13, 2019

+1

for #25622 22e8816

  • code changes are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no (relevant) differences. The bugfixes are essential for the code which is not yet in production.

@fabiocos
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

Analysis signature is missing: an explicit "merge" is needed

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 2421a1f into cms-sw:master Jan 14, 2019
@Dr15Jones Dr15Jones deleted the precedenceFixFormulaEvaluator branch January 14, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending code-checks-approved comparison-available orp-approved pending-signatures reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_5_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Dr15Jones @cmsbuild @slava77 @fabiocos @perrotta