Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop flags #2296 #2563

Merged
merged 1 commit into from Feb 20, 2014
Merged

Drop flags #2296 #2563

merged 1 commit into from Feb 20, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Feb 20, 2014

This is just like #2296, but it drops flags in BuildFile.xml, pending discussion. Please approve #2296 and then I'll merge this small fix.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Drop flags #2296

It involves the following packages:

DataFormats/GeometrySurface
DataFormats/GeometryVector
Geometry/CommonTopologies
RecoMuon/DetLayers
RecoTracker/CkfPattern
RecoTracker/TkDetLayers
TrackingTools/DetLayers
TrackingTools/GeomPropagators
TrackingTools/MaterialEffects
TrackingTools/PatternTools
TrackingTools/TrajectoryFiltering
TrackingTools/TrajectoryParametrization
TrackingTools/TrajectoryState
Utilities/BinningTools

@civanch, @Dr15Jones, @ianna, @mdhildreth, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf ktf mentioned this pull request Feb 20, 2014
@VinInn
Copy link
Contributor

VinInn commented Feb 20, 2014

thanks

@ianna
Copy link
Contributor

ianna commented Feb 20, 2014

+1

@ktf
Copy link
Contributor Author

ktf commented Feb 20, 2014

As agreed. Merging.

ktf added a commit that referenced this pull request Feb 20, 2014
@ktf ktf merged commit dbe0d9e into cms-sw:CMSSW_7_1_X Feb 20, 2014
@ktf ktf deleted the drop-flags-2296 branch February 20, 2014 17:54
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@civanch
Copy link
Contributor

civanch commented Feb 25, 2014

+1

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants