New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernized the memory handling of Hadronizers #25632
Conversation
-Switched from boost::shared_ptr to std::shared_ptr -Use std::unique_ptr directly to transfer memory ownership
The code-checks are being triggered in jenkins. |
We've been plagued with an infrequent crash in the nightly IB RelVals which seems to be coming from Pythia8HadronizerFilter. Our best guess is a memory related problem. The hope is modernizing the memory handling may help uncover the underlying problem. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25632/7949
|
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: GeneratorInterface/Core @alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
-Switched from boost::shared_ptr to std::shared_ptr
-Use std::unique_ptr directly to transfer memory ownership