Tunings to improve MTD track efficiency. Retain only best matching hit in a layer

[pmeridian]

Tunings to improve the efficiency for pions and PU200 of the MTD trackExtender. Retain only the best matching MTD hit in a layer to avoid issues @PU200 when increasing the estimator cuts.
Further improvements for pions require modification to the MTD DetLayer

More plots here:
https://meridian.web.cern.ch/meridian/plots/MTD/10_4_0_mtd3/TestTrackTuning/

@lgray @bendavid @franzoni @fabiocos

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25636/7954

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25636/7954/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25636/7954/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25636/7955

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @pmeridian for master.

It involves the following packages:

RecoMTD/TrackExtender

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[pmeridian]

please test

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32550/console Started: 2019/01/12 10:24

[cmsbuild]

+1
Tested at: 1f6dec1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25636/32550/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25636/32550/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153512
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

@pmeridian
it would be nice to see incremental comparisons from your changes.
Your plots posted with the PR do not allow to easily compare with the baseline/current PR.

[slava77]

+1

for #25636 1f6dec1

• code changes are in line with the PR description (selections are less restrictive now)
• jenkins tests pass and comparisons with the baseline show differences only in the D35 workflow (the only variant of phase2 in jenkins with the affected MTD reco).
  • the 10-event check shows roughly expected behavior: more tracks have non-default MTD extension with somewhat worse quality
    
    

[pmeridian]

Some comparisons here:

[kpedro88]

it would be worthwhile in the future to make these parameters configurable

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1