Adding time threshold compatibility to MTDThresholdClusterizer #25644
Conversation
|
The code-checks are being triggered in jenkins. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25644/7970
|
pmeridian
changed the title
|
A new Pull Request was created by @pmeridian for master. It involves the following packages: RecoLocalFastTime/FTLClusterizer @perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25644/7971
|
| @@ -256,6 +258,8 @@ MTDThresholdClusterizer::make_cluster( const FTLCluster::FTLHitPos& hit ) | |||
| for ( auto c = std::max(0,int(acluster.y[curInd]-1)); c < std::min(int(acluster.y[curInd]+2),int(theBuffer.columns())) && !stopClus; ++c) { | |||
| for ( auto r = std::max(0,int(acluster.x[curInd]-1)); r < std::min(int(acluster.x[curInd]+2),int(theBuffer.rows())) && !stopClus; ++r) { | |||
| if ( theBuffer.energy(r,c) > theHitThreshold) { | |||
| if (fabs(theBuffer.time(r,c) - seed_time) > theTimeThreshold*sqrt( theBuffer.time_error(r,c)*theBuffer.time_error(r,c) + seed_time_error*seed_time_error)) | |||
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25644/7972
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25644/7990
|
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
+upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This PR improves the MTD clusters @PU200 introducing a configurable time compatibility threshold (now set to a very loose @10sigma of the sigma of difference) between the seed and the hits to be attached to the cluster. It improves significantly the purity of the hits attached to the clusters as can be seen here:
Energy PU comparison in BTL with new configuration (Single MU)
Old configuration
Cluster size and time shows a similar behaviour:
Efficiency of the best hit matching is not affected:
Important to be used in the next mtd release
@lgray @bendavid @fabiocos @franzoni