Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim era 2018 and workflows #25683

Merged
merged 8 commits into from Jan 24, 2019

Conversation

ssekmen
Copy link
Contributor

@ssekmen ssekmen commented Jan 16, 2019

Added FastSim 2018 era and relevant workflows.
The workflow part needs a careful look from the PdmV side.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25683/8038

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ssekmen (Sezen Sekmen) for master.

It involves the following packages:

Configuration/Eras
Configuration/PyReleaseValidation
Configuration/StandardSequences

@cmsbuild, @prebello, @zhenhu, @kpedro88, @pgunnell, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@prebello
Copy link
Contributor

FYI @nwickram

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25683/8074

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

Pull request #25683 was updated. @cmsbuild, @prebello, @zhenhu, @kpedro88, @pgunnell, @franzoni, @fabiocos, @davidlange6 can you please check and sign again.

@kpedro88
Copy link
Contributor

please test
(can't actually test 2018 PU workflows yet, need to wait for relvals to be generated)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 18, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32699/console Started: 2019/01/18 16:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25683/32747/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25683/2018.1_TTbar_13_UP18+TTbarFS_13_UP18+HARVESTUP18FS+MINIAODMCUP18FS

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@zhenhu
Copy link
Contributor

zhenhu commented Jan 22, 2019

+1

@fabiocos
Copy link
Contributor

@ssekmen Run2_2018_FastSim looks identical to Run2_2017_FastSim, also in its use. Do we really need such a clone? Or am I missing anything?

@ssekmen
Copy link
Contributor Author

ssekmen commented Jan 22, 2019

@fabiocos , this was what I also thought initially, but apparently there are changes between Run2_2017 and Run2_2018. As we needed to inherit the changes in Run2_2018, we had to prepare a new era. @kpedro88 can confirm.

@kpedro88
Copy link
Contributor

@fabiocos indeed, it is as @ssekmen said. We need to have the Run2_2018 Era enabled to do 2018 simulation correctly, but as with 2017, GEM is not yet included in FastSim, so it has to be disabled.

@kpedro88
Copy link
Contributor

+upgrade

@fabiocos
Copy link
Contributor

@ssekmen @kpedro88 ok, you are correct

@fabiocos
Copy link
Contributor

+operations

the addition of the new Era is coherent with the purpose of the PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 226c9db into cms-sw:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants