ME0 localTrigger

[tahuang1991]

as discussed in GEM phase-2 simulation meeting, ME0 local trigger is added to CMSSW and ME0 trigger primitive is built from ME0 offline segment. The main change is to change ME0 trigger primitive data format and add ME0 trigger primitive producer.

presentation about this pull request:
https://indico.cern.ch/event/788586/contributions/3276348/attachments/1779305/2895175/Tao_ME0TP_20190116.pdf

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25685/8040

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25685/8040/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25685/8040/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25685/8042

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @tahuang1991 (TaoHuang) for master.

It involves the following packages:

DataFormats/GEMDigi
L1Trigger/ME0Trigger

@cmsbuild, @civanch, @kpedro88, @nsmith-, @rekovic, @mdhildreth can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dildick, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jshlee]

@tahuang1991 @pietverwilligen - ask to have this tested asap

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25685/32776/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

+upgrade

[tahuang1991]

Hi @civanch, @nsmith-, @rekovic, @mdhildreth what else should I do here?

[civanch]

@tahuang1991 , sorry for this question, why this producer is global?

[tahuang1991]

@civanch Since ME0 commission is a phase-2 upgrade project, full ME0 trigger, building ME0 trigger digi from ME0 hits, is not feasible in short future. However, L1 upgrade TDR requires ME0 trigger digi for some L1 studies. The GEM phase-2 simulation decided to take an intermedia solution that ME0 trigger digi could be built from offline segment as offline segment reconstruction package was already in place since muon phase-2 upgrade TDR. This producer is to build ME0 trigger digi from ME0 offline segment. Jason and Piet could confirm it @jshlee @pietverwilligen

[dildick]

@tahuang1991 I think that what Vladimir was asking was why the producer is a edm::global producer, as opposed to a edm::stream producer. The ME0SegmentProducer - on which this new code is based I presume - is an edm::stream, see [1].

[1]
https://github.com/cms-sw/cmssw/blob/master/RecoLocalMuon/GEMSegment/plugins/ME0SegmentProducer.cc

[tahuang1991]

@dildick @civanch I was following this example:
https://github.com/cms-sw/cmssw/blob/master/L1Trigger/ME0Trigger/plugins/ME0TriggerProducer.h

[jshlee]

@civanch - yes that is the case.

[civanch]

+1

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@tahuang1991 the added test files rely on inputs that are not available, and that is not specified how/where should be produced. I understand this is mostly for your convenience, and as they are not run as unit tests it could be ok. Still is there a simple way to have a fully working test chain?

[tahuang1991]

@fabiocos the added test file used normal data files generated from normal GEN-SIM-DIGI step. the reason why I added these configuration files is to only run ME0 reco + ME0 L1 and to avoid normal reco step which usually takes lots of CPU time and is not necessary for L1 study. I hope users could figure out how to run GEN-SIM-DIGI using cmsDriver command, otherwise I could add it.

[fabiocos]

@tahuang1991 ok, thanks for the clarification. Is there a specific workflow you are using?

[fabiocos]

+1

[tahuang1991]

no. I think workflow included in pull request will be used for ME0 trigger study in short future before full ME0 trigger is developed.