Complete low pT electron chain #25696

bainbrid · 2019-01-17T22:47:47Z

This PR builds on top of the #25455 PR, entitled "Low pT electrons (up to GsfTracks)".

The diff with respect to #25455 is here.

In summary, the PR:

completes the low pT electron chain by adding new modules and extending in a minor way the functionality of the existing Seeding module;
does not introduce any new DataFormat and simply reuses existing ones;
adds new collections to the Event;
does not alter any of the default EGamma code and workflows,
integrates within the miniAOD workflows,
relies on a new BDT model for ID purposes, found in this PR.

The modified existing modules are:

LowPtGsfElectronSeedProducer: this producer is minimally extended to produce a ValueMap indexed by an ElectronSeedRef. The PreIds hold the discriminator outputs of the BDT models used by this producer but the PreIds cannot be accessed directly from the GsfElectrons and related interfaces, while the ElectronSeeds are accessible. Hence this ValueMap allows the LowPtGsfElectronSeedValueMaps module to link the BDT output from the Seeding module to electrons, details below.

The new modules are:

LowPtGsfElectronSCProducer: A new "tracker-driven" SuperCluster producer, seeded by extrapolating the low pT GsfTracks and brem trajectories to the ECAL.
LowPtGsfElectronCoreProducer: this straightforward module produces GsfElectronCore objects and borrows heavily from the standard EGamma code.
LowPtGsfElectronProducer: this straightforward module produces GsfElectron objects and borrows heavily from the standard EGamma code.
lowPtGsfElectronSeedValueMapsProducer: This module consumes GsfElectrons and the ValueMap from the LowPtGsfElectronSeedProducer module. It produces two ValueMap indexed by a GsfElectronRef that contain the BDT discriminator values.
LowPtGsfElectronIDProducer: this module consumes GsfElectrons and makes use of a BDT model to ID the electrons, i.e. discriminate genuine electrons from fakes. The XML description of the model can be found in this PR to the cms-data repository.
miniAOD integration: modifications to the PhysicsTools/PatAlgos package allow to produced a slimmed low pT electron collection.

Here is the new sequence.

Here are the output collections stored for the RECO and AOD data tiers.

Here and here are the collections stored in the miniAOD data tier.

moved low pT ele sequence into highlevelreco

…criptions

cmsbuild · 2019-01-23T18:23:10Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-01-23T18:29:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25696/8151

This PR adds an extra 124KB to repository
Found files with invalid states:
- Configuration/Eras/python/Modifier_BParking_cff.py:
  - Added: 1503e52
  - Deleted: 7f6c948
- Configuration/Eras/python/Modifier_bParkingOpen_cff.py:
  - Added: a922315
  - Deleted: 498125c

cmsbuild · 2019-01-23T18:30:19Z

Pull request #25696 was updated. @perrotta, @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @franzoni, @slava77, @santocch, @fabiocos, @davidlange6 can you please check and sign again.

cmsbuild · 2019-01-23T19:08:02Z

The code-checks are being triggered in jenkins.

bainbrid · 2019-01-23T19:09:17Z

We have pushed a fix for errors observed with mAOD when running over data.
Please can you runTheMatrix again?

cmsbuild · 2019-01-23T19:14:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25696/8152

This PR adds an extra 140KB to repository
Found files with invalid states:
- Configuration/Eras/python/Modifier_BParking_cff.py:
  - Added: 1503e52
  - Deleted: 7f6c948
- Configuration/Eras/python/Modifier_bParkingOpen_cff.py:
  - Added: a922315
  - Deleted: 498125c

bainbrid · 2019-01-23T19:15:32Z

The numbers below show the additional footprint (Bytes) to RECO and AOD from the new low pT electron collections, as determined with 25202 TTBar (PU=50). The "standard" RECO workflows use the Tight working point and pT > 1 GeV threshold. The "bParking" era uses the Loose working point and pT > 0.5 GeV threshold. It's worth noting that the "bParking" numbers are likely to be substantially smaller for data, because of a mean pileup of ~20.

Collection                                                  Standard  bParking
recoGsfTracks_lowPtGsfEleGsfTracks__RECO		      1403.0    6043.2     
recoSuperClusters_lowPtGsfElectronSuperClusters__RECO	       465.8    1655.0     
recoCaloClusters_lowPtGsfElectronSuperClusters__RECO	      2977.6    6171.7     
recoGsfElectronCores_lowPtGsfElectronCores__RECO	       124.5     276.6     
recoGsfElectrons_lowPtGsfElectrons__RECO		      3301.6   13067.0     
floatedmValueMap_lowPtGsfElectronSeedValueMaps_ptbiased_RECO   112.4     227.7     
floatedmValueMap_lowPtGsfElectronSeedValueMaps_unbiased_RECO   112.4     227.2     
floatedmValueMap_lowPtGsfElectronID__RECO                      105.0     214.7     
TOTALS                                                        8808     27880

cmsbuild · 2019-01-23T19:17:10Z

Pull request #25696 was updated. @perrotta, @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @franzoni, @slava77, @santocch, @fabiocos, @davidlange6 can you please check and sign again.

perrotta · 2019-01-23T19:23:06Z

@bainbrid could you please rebase on top of a recent 10_5_X IB, so that this PR will contain only the additions on top of #25679?
If you also squash all commits then you can get rid of the files with invalid state mentioned in #25696 (comment)

bainbrid · 2019-01-23T21:23:02Z

@perrotta how does this look? Do I force push to this branch? Or create a new PR?

perrotta · 2019-01-23T21:32:39Z

@bainbrid : hard to tell at the first glance. The reduction in the number of lines is rather similar to the number of lines in #25679, and this looks healty, indeed.
I would open a new PR with your latest commit, and close this one once we are sure that the operation ended up as expected.

bainbrid · 2019-01-23T21:45:04Z

@perrotta We may have one or two final commits to make, pending some final checks. Should I still go ahead?

perrotta · 2019-01-23T21:47:59Z

Up to you: if the other commits are coming, we can just wait for them. bainbrid <notifications@github.com> ha scritto:

…

@perrotta We may have one or two final commits to make, pending some final checks. Should I still go ahead? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #25696 (comment)

bainbrid · 2019-01-23T21:51:48Z

ok, I did it. #25753

perrotta · 2019-01-25T11:17:50Z

-1
(the review will continue in #25753)

bainbrid and others added 21 commits January 15, 2019 16:37

GsfTracks using LowPtGsfElectronSeedProducer

ab2a292

moved low pT ele sequence into highlevelreco

updated model filenames

5d6eb57

only consume PF or KF tracks depending on UsePfTracks configurable

86ff5eb

fillDescriptions

f0f4658

consume collections only when necessary

0782b0e

removed commented line

61e635f

comments from perotta

c5c761d

fixing low pt eles for fastsim

1b3dd57

fixing low pt ele for phaseII

aa2ffc9

explicitly specify low pT GsfTracks

d1a7fc5

const args, comment from mauro

82d13fb

dPhi(traj,clu) * charge

5409453

modifiers for BParking + triv tidy up

1503e52

fix white space, tidy up

7a3eedf

move dphi,deta inside if clause; protect against chi2==0.

8c156c8

rename to bParking (lower case)

7f6c948

moved unncessary casts, changed others to c++ casts

4a196ae

moved track fitter and cloner and builder into loop() method

b912e0e

standard pT>1.0, bParking pT>0.5

82d3b67

complete low pT electron chain

a922315

simplified to be consistent with new GsfElectronBaseProducer::fillDes…

524a0dd

…criptions

cmsbuild added this to the CMSSW_10_5_X milestone Jan 17, 2019

cmsbuild added analysis-pending code-checks-pending comparison-pending fastsim-pending operations-pending orp-pending pending-signatures reconstruction-pending labels Jan 17, 2019

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 23, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 23, 2019

bainbrid added 2 commits January 23, 2019 19:54

added LowPtElectrons

95ba0be

added LowPtElectrons

72a21b5

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 23, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 23, 2019

bainbrid mentioned this pull request Jan 23, 2019

Complete low pT electron chain (2) #25753

Merged

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Jan 25, 2019

bainbrid closed this Jan 30, 2019

bainbrid deleted the LowPtElectronsFull_105X branch August 6, 2019 12:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complete low pT electron chain #25696

Complete low pT electron chain #25696

bainbrid commented Jan 17, 2019 •

edited

cmsbuild commented Jan 23, 2019

cmsbuild commented Jan 23, 2019

cmsbuild commented Jan 23, 2019

cmsbuild commented Jan 23, 2019

bainbrid commented Jan 23, 2019

cmsbuild commented Jan 23, 2019

bainbrid commented Jan 23, 2019 •

edited

cmsbuild commented Jan 23, 2019

perrotta commented Jan 23, 2019

bainbrid commented Jan 23, 2019

perrotta commented Jan 23, 2019

bainbrid commented Jan 23, 2019

perrotta commented Jan 23, 2019 via email

bainbrid commented Jan 23, 2019

perrotta commented Jan 25, 2019

Complete low pT electron chain #25696

Complete low pT electron chain #25696

Conversation

bainbrid commented Jan 17, 2019 • edited

cmsbuild commented Jan 23, 2019

cmsbuild commented Jan 23, 2019

cmsbuild commented Jan 23, 2019

cmsbuild commented Jan 23, 2019

bainbrid commented Jan 23, 2019

cmsbuild commented Jan 23, 2019

bainbrid commented Jan 23, 2019 • edited

cmsbuild commented Jan 23, 2019

perrotta commented Jan 23, 2019

bainbrid commented Jan 23, 2019

perrotta commented Jan 23, 2019

bainbrid commented Jan 23, 2019

perrotta commented Jan 23, 2019 via email

bainbrid commented Jan 23, 2019

perrotta commented Jan 25, 2019

bainbrid commented Jan 17, 2019 •

edited

bainbrid commented Jan 23, 2019 •

edited