New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed header inconsistency in CoralServiceWrapper #25724
Fixed header inconsistency in CoralServiceWrapper #25724
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25724/8116
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CondCore/CondDB @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@Dr15Jones for my understanding, was this spotted by some test? Looking back at https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25662/32598/summary.html there was no complaint that I could see |
@fabiocos it was found by the 'Header consistency' checks in the IB: |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@Dr15Jones interesting, this wasn't caught by the PR header consistency check... @ggovi could you please gin it so as we fix this issue? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
No description provided.