Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion from lowPtGsfTracks backported to 10_2_x #25761

Conversation

nancymarinelli
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 24, 2019

A new Pull Request was created by @nancymarinelli for CMSSW_10_2_X.

It involves the following packages:

DataFormats/EgammaCandidates
DataFormats/EgammaTrackReco
RecoEgamma/Configuration
RecoEgamma/EgammaPhotonProducers

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @rovere, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Feb 6, 2019

-1
Please implement in this backport PR the same adjustments that were finally introduced in #25595, now merged in the master. Please keep in mind that in 10_2 the new low pt electrons will be produced only conditionally to the bParking era

@nancymarinelli
Copy link
Contributor Author

nancymarinelli commented Feb 6, 2019 via email

@nancymarinelli
Copy link
Contributor Author

@perrotta @bainbrid OK for the era, I see what has been done for lowPt electrons. I will follow the same lines

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Pull request #25761 was updated. @perrotta, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Feb 6, 2019

backport of #25595

@perrotta
Copy link
Contributor

perrotta commented Feb 6, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33015/console Started: 2019/02/06 12:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25761/33015/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007209
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Feb 6, 2019

+1

  • Correct backport of the corresponding pull request merged in the master
  • In 10_2_X, lowPtElectrons reconstruction is only performed if the bParking era is enabled: there must be no changes in the default processing, and none is seen in the outputs of the jenkins tests
  • Verified that the newly added modules/sequences correctly run when the bParking era is enabed

@nancymarinelli
Copy link
Contributor Author

@perrotta What else is needed to be merged ?

@kpedro88
Copy link
Contributor

It will be merged for the next 10_2_X release

@fabiocos
Copy link
Contributor

+operations

the backport of modifications to the StandardSequences differs from the master version in the request of being activated only for the bParking Era

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9eb4305 into cms-sw:CMSSW_10_2_X Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants