Fixed possible buffer overflow in CSCTriggerPrimitivesReader #25800

Dr15Jones · 2019-01-30T16:51:46Z

This was spotted when building with ASAN.

cmsbuild · 2019-01-30T16:52:12Z

The code-checks are being triggered in jenkins.

Dr15Jones · 2019-01-30T16:52:36Z

This fixes the build errors in ASAN and TSAN IBs. E.g.

  /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3476:6: error: '%d' directive writing between 1 and 10 bytes into a region of size 5 [-Werror=format-overflow=]
  void CSCTriggerPrimitivesReader::drawCompHistos() {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3476:6: note: directive argument in the range [1, 2147483647]
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3559:12: note: 'sprintf' output between 6 and 15 bytes into a destination of size 7
     sprintf(pagenum, "- %d -", page);  t.DrawText(0.9, 0.02, pagenum);
     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
  /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3476:6: error: '%d' directive writing between 1 and 10 bytes into a region of size 5 [-Werror=format-overflow=]
  void CSCTriggerPrimitivesReader::drawCompHistos() {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3476:6: note: directive argument in the range [1, 2147483647]
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3611:12: note: 'sprintf' output between 6 and 15 bytes into a destination of size 7
     sprintf(pagenum, "- %d -", page);  t.DrawText(0.9, 0.02, pagenum);
     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
  /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3476:6: error: '%d' directive writing between 1 and 10 bytes into a region of size 5 [-Werror=format-overflow=]
  void CSCTriggerPrimitivesReader::drawCompHistos() {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3476:6: note: directive argument in the range [1, 2147483647]
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3662:12: note: 'sprintf' output between 6 and 15 bytes into a destination of size 7
     sprintf(pagenum, "- %d -", page);  t.DrawText(0.9, 0.02, pagenum);
     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
  /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3476:6: error: '%d' directive writing between 1 and 10 bytes into a region of size 5 [-Werror=format-overflow=]
  void CSCTriggerPrimitivesReader::drawCompHistos() {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3476:6: note: directive argument in the range [1, 2147483647]
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3714:12: note: 'sprintf' output between 6 and 15 bytes into a destination of size 7
     sprintf(pagenum, "- %d -", page);  t.DrawText(0.9, 0.02, pagenum);
     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
  /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3476:6: error: '%d' directive writing between 1 and 10 bytes into a region of size 5 [-Werror=format-overflow=]
  void CSCTriggerPrimitivesReader::drawCompHistos() {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3476:6: note: directive argument in the range [1, 2147483647]
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a15cec9e1aeb53dd2aadac15d97bfeab/opt/cmssw/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_TSAN_X_2019-01-25-2300/src/L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:3765:12: note: 'sprintf' output between 6 and 15 bytes into a destination of size 7
     sprintf(pagenum, "- %d -", page);  t.DrawText(0.9, 0.02, pagenum);
     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~

cmsbuild · 2019-01-30T16:58:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25800/8234

This PR adds an extra 40KB to repository

Dr15Jones · 2019-01-30T16:58:33Z

please test

cmsbuild · 2019-01-30T16:59:05Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32904/console Started: 2019/01/30 18:00

cmsbuild · 2019-01-30T16:59:06Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@nsmith-, @rekovic, @cmsbuild can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @dildick this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-01-30T19:18:26Z

+1
Tested at: f0c6fe1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25800/32904/summary.html

cmsbuild · 2019-01-30T19:18:30Z

Comparison job queued.

cmsbuild · 2019-01-30T20:37:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25800/32904/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3097440
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3097242
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

Dr15Jones · 2019-02-04T15:21:15Z

ping

fabiocos · 2019-02-05T21:01:57Z

@rekovic this is a small fix, could you please check and sign or comment?

rekovic · 2019-02-08T05:41:48Z

+1

cmsbuild · 2019-02-08T05:42:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-02-08T09:23:29Z

+1

Fixed possible buffer overflow in CSCTriggerPrimitivesReader

f0c6fe1

This was spotted when building with ASAN.

cmsbuild added this to the CMSSW_10_5_X milestone Jan 30, 2019

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Jan 30, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 30, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 30, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 30, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jan 30, 2019

cmsbuild removed l1-pending pending-signatures labels Feb 8, 2019

cmsbuild added fully-signed l1-approved labels Feb 8, 2019

cmsbuild added orp-approved and removed orp-pending labels Feb 8, 2019

cmsbuild merged commit a2c9e87 into cms-sw:master Feb 8, 2019

Dr15Jones deleted the fixCSCTriggerPrimitivesReader branch February 9, 2019 22:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed possible buffer overflow in CSCTriggerPrimitivesReader #25800

Fixed possible buffer overflow in CSCTriggerPrimitivesReader #25800

Dr15Jones commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

Dr15Jones commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

Dr15Jones commented Jan 30, 2019

cmsbuild commented Jan 30, 2019 •

edited

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

Dr15Jones commented Feb 4, 2019

fabiocos commented Feb 5, 2019

rekovic commented Feb 8, 2019

cmsbuild commented Feb 8, 2019

fabiocos commented Feb 8, 2019

Fixed possible buffer overflow in CSCTriggerPrimitivesReader #25800

Fixed possible buffer overflow in CSCTriggerPrimitivesReader #25800

Conversation

Dr15Jones commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

Dr15Jones commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

Dr15Jones commented Jan 30, 2019

cmsbuild commented Jan 30, 2019 • edited

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

Dr15Jones commented Feb 4, 2019

fabiocos commented Feb 5, 2019

rekovic commented Feb 8, 2019

cmsbuild commented Feb 8, 2019

fabiocos commented Feb 8, 2019

cmsbuild commented Jan 30, 2019 •

edited