New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant configuration settings for siPixelDigis #25815
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25815/8252
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: EventFilter/SiPixelRawToDigi @cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @makortel , I noticed it a few second after having hit the return key
But for some reason the message with the correction that I wrote at once was not sent.
I have already signed this, anyhow: sorry for the noise
+1 |
These are already set in
fillDescriptions()
, so there is no need to specify them again. This cleanup helps the Patatrack GPU work.Tested in 10_5_0_pre1, no changes expected.