Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate events without MPI if LBCR or CRSS performed with MPI. #25851

Merged
merged 1 commit into from Feb 5, 2019

Conversation

EmyrClement
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25851/8310

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

A new Pull Request was created by @EmyrClement for master.

It involves the following packages:

GeneratorInterface/SherpaInterface

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano, @thuer this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Feb 4, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32987/console Started: 2019/02/04 14:24

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25851/32987/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@efeyazgan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 4, 2019

@EmyrClement was this practically tested? The PR test does not probe this piece of code...

@qliphy
Copy link
Contributor

qliphy commented Feb 5, 2019

@fabiocos The issue was identified during last Friday's Sherpa workshop. MakeSherpaLibs.sh is used to create Sherpa gridpack, but also contains 101 events production for a sanity check. It was found by @EmyrClement that with MPI, the sanity check step is very slow. (It will not affect the afterwards event producing with sherpa gridpack)

Both us have checked with this PR and it works well.

@fabiocos
Copy link
Contributor

fabiocos commented Feb 5, 2019

+1

@EmyrClement @qliphy thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants