New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate events without MPI if LBCR or CRSS performed with MPI. #25851
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25851/8310
|
A new Pull Request was created by @EmyrClement for master. It involves the following packages: GeneratorInterface/SherpaInterface @alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@EmyrClement was this practically tested? The PR test does not probe this piece of code... |
@fabiocos The issue was identified during last Friday's Sherpa workshop. MakeSherpaLibs.sh is used to create Sherpa gridpack, but also contains 101 events production for a sanity check. It was found by @EmyrClement that with MPI, the sanity check step is very slow. (It will not affect the afterwards event producing with sherpa gridpack) Both us have checked with this PR and it works well. |
+1 @EmyrClement @qliphy thanks for the clarification |
No description provided.