Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim memory fix in TrajectorySeedProducer in 94X #25865

Merged
merged 1 commit into from Feb 13, 2019

Conversation

angirar
Copy link
Contributor

@angirar angirar commented Feb 5, 2019

Backport of #25824

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2019

A new Pull Request was created by @angirar for CMSSW_9_4_X.

It involves the following packages:

FastSimulation/Tracking

@cmsbuild, @lveldere, @civanch, @ssekmen, @mdhildreth can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@angirar angirar changed the title FastSim memory fix in 94X FastSim memory fix in TrajectorySeedProducer in 94X Feb 5, 2019
@ssekmen
Copy link
Contributor

ssekmen commented Feb 5, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33008/console Started: 2019/02/05 19:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25865/33008/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 108
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721223
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@ssekmen
Copy link
Contributor

ssekmen commented Feb 12, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2e82e0c into cms-sw:CMSSW_9_4_X Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants