Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new and cleaned up existing Geant4 Physics Lists #25878

Merged
merged 1 commit into from Feb 7, 2019

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Feb 6, 2019

Clean up physics options for Genat4 simulation:

  1. Added extra Physics Lists FTFP_BERT_EMN and QGSP_FTFP_BERT_EMN where of top of CMS production configuration for Run-2 more accurate e+- transport provided for HGCal. This should be faster than EMY and EMZ options from Geant4 distribution.
  2. cleaned up EML and EMN electromagnetic model configurations
  3. dump of dEdx, range and cross section tables in the ASCII format instead of the binary format

Should not affect production and recommended to try for HGCal (@bsunanda )

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25878/8341

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application
SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Feb 6, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33025/console Started: 2019/02/06 19:19

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25878/33025/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Feb 7, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 7, 2019

@civanch could you please clarify the implications of the update of the standard EM physics model? What is the expected physics impact (although no change is seen in the tests)? IS this just a technical code refactoring?

@civanch
Copy link
Contributor Author

civanch commented Feb 7, 2019

@fabiocos , in the production EM physics I change only 1 comment, so nothing should be different in regression tests. All modifications affect upgrade PhysicsList for R&D and PhysicsList for neutron background studies.

I have checked that the new PhysicsLists are working properly.

@fabiocos
Copy link
Contributor

fabiocos commented Feb 7, 2019

@civanch ok, in FTFP_BERT_EMM we use CMSEmStandardPhysicsLPM

https://cmssdt.cern.ch/lxr/source/SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMM.cc#0002

@fabiocos
Copy link
Contributor

fabiocos commented Feb 7, 2019

+1

@cmsbuild cmsbuild merged commit 5b619da into cms-sw:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants