New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new and cleaned up existing Geant4 Physics Lists #25878
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25878/8341
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@civanch could you please clarify the implications of the update of the standard EM physics model? What is the expected physics impact (although no change is seen in the tests)? IS this just a technical code refactoring? |
@fabiocos , in the production EM physics I change only 1 comment, so nothing should be different in regression tests. All modifications affect upgrade PhysicsList for R&D and PhysicsList for neutron background studies. I have checked that the new PhysicsLists are working properly. |
@civanch ok, in FTFP_BERT_EMM we use CMSEmStandardPhysicsLPM https://cmssdt.cern.ch/lxr/source/SimG4Core/PhysicsLists/plugins/FTFPCMS_BERT_EMM.cc#0002 |
+1 |
Clean up physics options for Genat4 simulation:
Should not affect production and recommended to try for HGCal (@bsunanda )