Add label for pixel digitizer in SiPixelQualityESProducer #25885
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25885/8349
|
|
A new Pull Request was created by @tsusa (Tatjana Susa) for master. It involves the following packages: CalibTracker/SiPixelESProducers @civanch, @tocheng, @cmsbuild, @franzoni, @mdhildreth, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 9ca0411 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_5_X_2019-02-07-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Feb 8 13:14:45 2019-date Fri Feb 8 13:07:48 2019 s - exit: 16640 |
|
Comparison job queued. |
| # To use the label for 2018 data, uncomment next two lines, new GT needed | ||
| #from Configuration.Eras.Modifier_run2_SiPixel_2018_cff import run2_SiPixel_2018 | ||
| #run2_SiPixel_2018.toModify(SiPixelSimBlock, SiPixelQualityLabel = 'forDigitizer',) | ||
|
|
||
| from Configuration.ProcessModifiers.premix_stage1_cff import premix_stage1 | ||
| premix_stage1.toModify(SiPixelSimBlock, |
There was a problem hiding this comment.
I see the two lines are already uncommented. So the feature is switched on, in contrast what is written in the PR description?
Likely the reason why the AddOn tests fail, given the error messages there.
There was a problem hiding this comment.
Hi @Martin-Grunewald, those two lines are still commented
# To use the label for 2018 data, uncomment next two lines, new GT needed
#from Configuration.Eras.Modifier_run2_SiPixel_2018_cff import run2_SiPixel_2018
#run2_SiPixel_2018.toModify(SiPixelSimBlock, SiPixelQualityLabel = 'forDigitizer',)
There was a problem hiding this comment.
Well, it is switched on somewhere:
----- Begin Fatal Exception 08-Feb-2019 13:14:16 CET-----------------------
An exception of category 'NoProxyException' occurred while
[0] Processing stream begin Run run: 1 stream: 2
[1] Calling method for module EventSetupRecordDataGetter/'hltGetConditions'
[2] Using EventSetup component SiPixelQualityESProducer/'siPixelQualityESProducer' to make data SiPixelQuality/'forDigitizer' in record SiPixelQualityRcd
Exception Message:
No data of type "SiPixelQuality" with label "forDigitizer" in record "SiPixelQualityFromDbRcd"
Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-available
and removed
comparison-pending
code-checks-approved
comparison-available
labels
|
Pull request #25885 was updated. @civanch, @tocheng, @cmsbuild, @franzoni, @mdhildreth, @pohsun, @fabiocos, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test workflow 158.0 |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@civanch could you please check and comment or sign? I would like to converge on this before pre2 |
|
+operations the update of the Era looks coherent with the purpose of the PR to activate the new mechanism for 2018 (and Run2) |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This PR introduces the label for the
SiPixelQualityRcdin order to treat the damaged pixels behind broken DCDC converters the same way in data and in simulation. The PR was explained at the RECO meeting https://indico.cern.ch/event/787904/contributions/3288669/subcontributions/273135/attachments/1785559/2906928/tanjaReco_25012019.pdf.The feature is switched off by default. In order to switch it on:
SiPixelQualitywith the label "forDigitizer" is neededThe Era mechanism is used to activate the feature only for >= 2018