Added extra protection to Geant4 SteppingAction

[civanch]

During R&D studies with FTFP_BERT_EMZ Physics List a weird problem was identified. To fix this problem an extra protection is added to the SteppingAction class: on each step check on NaN values and kill problematic tracks. This may be also useful for production (no reports so far from production about such cases).

CMSSteppingVerbose class is used only for debugging of a problem. It is extended in order to be more informative for debugging on complicated crashes.

Results of normal runs should not be affected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[civanch]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25894/8366

• This PR adds an extra 20KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33058/console Started: 2019/02/08 17:54

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application
SimG4Core/Notification

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 18a0876
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25894/33058/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ff51777
d643d29
f7ce74f
1eb713a
a2c9e87
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25894/33058/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25894/33058/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25894/33058/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 28765 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 57400
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 3039837
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2.457 KiB( 31 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.192 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.063 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): 1.461 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 1.251 KiB SiStrip/MechanicalView
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25894/8378

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #25894 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33072/console Started: 2019/02/11 09:21

[cmsbuild]

+1
Tested at: b4beacc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25894/33072/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25894/33072/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1