Manage PluginFactory plugins with unique_ptr in RecoMuon

[makortel]

This PR is preparatory work to change the PluginFactory to return a std::unique_ptr.

In addition I removed an unnecessary ParameterSet member from MuIsoDepositProducer, and did more thorough migration from raw pointers to unique_ptr and cleanup in RecoMuon/TrackerSeedGenerator.

Tested in CMSSW_10_5_X_2019-02-05-1100 , no changes expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25921/8404

• This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25921/8404/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25921/8404/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25921/8405

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

RecoMuon/L2MuonIsolationProducer
RecoMuon/L3MuonIsolationProducer
RecoMuon/MuonIdentification
RecoMuon/MuonIsolation
RecoMuon/MuonIsolationProducers
RecoMuon/TrackerSeedGenerator

@Martin-Grunewald, @cmsbuild, @perrotta, @fwyzard, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @folguera, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @drkovalskyi, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33102/console Started: 2019/02/12 19:07

[cmsbuild]

+1
Tested at: 0d8ad46
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25921/33102/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25921/33102/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[Martin-Grunewald]

+1

[perrotta]

+1

• The update is technical, and corresponds to what declared in the PR description
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1