Fix exception to action table lifetime #2595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a purely technical fix for a segmentation fault observed by Mike Hildreth when running workflows using data premixing.
An ExceptionToActionTable object is used to determine the course of action after an exception is caught.
Unfortunately, in the class that handles processing premixed data, an ExceptionToActionTable was constructed as a temporary on the stack whose lifetime was over before it was used.
This fix allocates it on the heap, held by a std::unique_ptr, making it's lifetime the same as the containing class.
This problem does not exist prior to 7_0_X as the affected code was new for 7_0_X.