Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception to action table lifetime #2595

Merged
merged 2 commits into from Feb 24, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 22, 2014

This is a purely technical fix for a segmentation fault observed by Mike Hildreth when running workflows using data premixing.
An ExceptionToActionTable object is used to determine the course of action after an exception is caught.
Unfortunately, in the class that handles processing premixed data, an ExceptionToActionTable was constructed as a temporary on the stack whose lifetime was over before it was used.
This fix allocates it on the heap, held by a std::unique_ptr, making it's lifetime the same as the containing class.
This problem does not exist prior to 7_0_X as the affected code was new for 7_0_X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_X.

Fix exception to action table lifetime

It involves the following packages:

Mixing/Base

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Feb 23, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 24, 2014
Simulation fixes -- Fix exception to action table lifetime
@ktf ktf merged commit 428bca9 into cms-sw:CMSSW_7_1_X Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@wmtan wmtan deleted the FixExceptionToActionTableLifetime branch February 27, 2014 04:36
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants