Run2-sim29 Avoid crashes in SteppingVerboseAction

[bsunanda]

No description provided.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25950/8445

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4Core/TrackingVerbose

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33150/console Started: 2019/02/15 17:53

[cmsbuild]

-1

Tested at: b3d4d5d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25950/33150/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Fri Feb 15 19:15:28 2019-date Fri Feb 15 19:06:48 2019 s - exit: 35584

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25950/33150/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3098286
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3098088
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

@bsunanda , inside g4SimHits main configuration file there are options allowing different level of stepping verbosity. I do not think, that this sub-library can provide anything more detailed.

In the main script there are possibilities to select event but number, track by id, use different level of printout. Please, try out these features.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1
Tested at: b3d4d5d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25950/33179/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25950/33179/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3098286
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3098088
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1
now it is working but I would simply remove this sub-library

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@civanch @bsunanda sorry but I am confused about this PR as there is no description at all, and I am not sure about which sub-library you are discussing. Could you please specify the problem addressed by this PR? What should be removed?

[fabiocos]

hold

pending a clarification

[cmsbuild]

Pull request has been put on hold by @fabiocos
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[fabiocos]

unhold

I see the effect of this PR, this anyway means that the SteppingVerbose is no more an option. I have verified that if this setting is activated it runs smoothly without crashing:

TV: Get the Tracking Manager: 0 and the SteppingVerbose: 0

[fabiocos]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.