Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ECAL pedestal tag to be prompt sync and remove PPS alignment tag in GT #25961

Merged
merged 1 commit into from Feb 16, 2019

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Feb 16, 2019

Hello all,

The PR is used to fix the issue reported at #25959
brought from merging PR #25929 which updated GTs in CMSSW to 105X.
There are two issues fixed in the PR

  1. The relval data GT in CMSSW is used to test PCL workflows, so the tags involved into the PCL workflow have to be prompt synced or maybe pcl synced in the relval data GT

  2. The Prompt-Like data GT with HE sector failure contains a tag for PPS alignment. This tag needs to be removed because the current PPS alignment ES producer uses alignment from local XML file.
    In addition, the prompt synced tags with the same payloads are used in Prompt-Like GT to be on the safe side.

The following GT updates are included :

Offline relval data GT

The updated GT is
https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/105X_dataRun2_relval_v6
Diff :
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/105X_dataRun2_relval_v6/105X_dataRun2_relval_v5

  • ECAL pedestal changes from prompt to offline

Prompt like data GT with HE sector failure

The updated GT is
https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/105X_dataRun2_PromptLike_HEfail_v5
Diff :
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/105X_dataRun2_PromptLike_HEfail_v5/105X_dataRun2_PromptLike_HEfail_v3

  • remove PPS alignment tag which has conflict with the current PPS alignment ES producer
  • use prompt synced PPS timing tag with the same payloads as the offline synced one to be on the safer side

Prompt like data GT

The updated GT is
https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/105X_dataRun2_PromptLike_v6
Diff :
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/105X_dataRun2_PromptLike_v6/105X_dataRun2_PromptLike_v5

  • use prompt synced PPS timing tag with the same payloads as the offline synced one to be on the safer side
  • remove unlabelled pixel 2D template because it is used at nowhere

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@tocheng tocheng mentioned this pull request Feb 16, 2019
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25961/8461

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tocheng
Copy link
Contributor Author

tocheng commented Feb 16, 2019

@cmsbuild please test workflow 1010.0, 136.8642, 136.8643

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33162/console Started: 2019/02/16 18:13

@fabiocos
Copy link
Contributor

@tocheng so you confirm that for PPS the XML alignment file should be used, and not the record in the GT? Is there a plan to move to GT tags?

@tocheng
Copy link
Contributor Author

tocheng commented Feb 16, 2019

@tocheng so you confirm that for PPS the XML alignment file should be used, and not the record in the GT? Is there a plan to move to GT tags?

Hello @fabiocos ,
for the moment we should use XML file alignment.
The deploy of PPS alignment from DB will be the next step.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25961/33162/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25961/1010.0_TestEnableEcalHCAL2017B+TestEnableEcalHCAL2017B+TIER0EXPTE+ALCAEXPTE+ALCAHARVDTE
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25961/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25961/136.8643_RunJetHT2018BBadHcalMitig+RunJetHT2018BBadHcalMitig+HLTDR2_2018_BadHcalMitig+RECODR2_2018reHLT_skimJetHT_Prompt_BadHcalMitig+HARVEST2018_BadHcalMitig

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1752 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3098286
  • DQMHistoTests: Total failures: 50
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3098033
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.035 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 136.731 ): 0.035 KiB JetMET/SUSYDQM
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@tocheng
Copy link
Contributor Author

tocheng commented Feb 16, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 93343e8 into cms-sw:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants