-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[102X] Backport script for multithreaded tarball management #25966
Conversation
A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_2_X. It involves the following packages: GeneratorInterface/LHEInterface @alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
code-checks |
The code-checks are being triggered in jenkins. |
@efeyazgan @qliphy @alberto-sanchez @perrozzi I would imagine that this is what you would like to have now, please confirm |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25966/8466
|
please test not really testing this PR |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This added file "run_generic_tarball_cvmfs_manual_multithread.sh" is fine. But after recent chat with @perrozzi and @efeyazgan , we think it alone doesn't ensure a multithread mode for gridpack running. A local test shows it just launches separate jobs one by one and the total timing is the same. In other words, we may still need additional update from e.g. madgraph side to be able to distribute jobs with different threads. However, the file can be merged for next step's reference. We can also use this backport from #24653 to replace #24344. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
102X Backport of #24653: Multi thread lhe to increase GEN efficiency.
Meant to replace #24344 which appears to be an obsolete intermediate version.