Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[102X] Backport script for multithreaded tarball management #25966

Merged
merged 1 commit into from Feb 19, 2019

Conversation

fabiocos
Copy link
Contributor

102X Backport of #24653: Multi thread lhe to increase GEN efficiency.
Meant to replace #24344 which appears to be an obsolete intermediate version.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/LHEInterface

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

code-checks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fabiocos
Copy link
Contributor Author

@efeyazgan @qliphy @alberto-sanchez @perrozzi I would imagine that this is what you would like to have now, please confirm

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25966/8466

  • This PR adds an extra 12KB to repository

@fabiocos
Copy link
Contributor Author

please test

not really testing this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 18, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33177/console Started: 2019/02/18 18:19

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25966/33177/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007207
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Feb 19, 2019

This added file "run_generic_tarball_cvmfs_manual_multithread.sh" is fine. But after recent chat with @perrozzi and @efeyazgan , we think it alone doesn't ensure a multithread mode for gridpack running. A local test shows it just launches separate jobs one by one and the total timing is the same. In other words, we may still need additional update from e.g. madgraph side to be able to distribute jobs with different threads.

However, the file can be merged for next step's reference. We can also use this backport from #24653 to replace #24344.

@fabiocos
Copy link
Contributor Author

@qliphy thank you for the clarification. In any case this would bring 10_2_X in sync with master in a fully backward compatible way, while #24344 does not. Up to you decide whether you want it or not. If as I believe #24344 is obsolete, please let me know whether it may just be closed

@qliphy
Copy link
Contributor

qliphy commented Feb 19, 2019

@fabiocos Yes I agree #24344 can be closed.

@qliphy
Copy link
Contributor

qliphy commented Feb 19, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit c8a64b1 into cms-sw:CMSSW_10_2_X Feb 19, 2019
@fabiocos fabiocos deleted the fc-lhemultithread branch February 28, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants