Phase 2 Trackers. Remove T7 and T8 (IT large pixels study). Add T14 (New OT envelope + Numerous updates in IT). #25988

ghugo83 · 2019-02-20T20:53:36Z

This PR adds Tracker T14, and its associated workflows.
This Tracker has a reduced OT envelope + numerous changes in IT. More details in [1].

Full Tracker description is accessible at: http://ghugo.web.cern.ch/ghugo/layouts/T14/OT616_200_IT613/info.html

Geometry scenario is: 2023D40.
Workflows are: 286xx (no PU), 288xx (PU).

This Tracker should be compared with T12 (2023D36 scenario).

This PR also removes the Trackers which were used for large pixel studies (T7 and T8 + their associated workflows).

NB 1: The DetIds are different (since major geometry changes, notably changes in number of modules).
The list of the new DetIds is in PixelSkimmedGeometryT14.txt (external).
See cms-data/SLHCUpgradeSimulations-Geometry#11.
Please do not launch any test without this external file.

NB 2: As discussed with @emiglior , all changes are put in one Tracker here.
It can be potentially split in 2 Trackers with 'OT changes only' and 'IT changes only' respectively if ever needed.

NB 3: Further changes to come (not included in this PR):

Skewed TBPX.
Significant MB updates.

[1] Tracker changes in this PR (versus T12 description):
Outer Tracker:
Reduced OT envelope, to leave space for BTL + IT insertion.
This notably leads to:

TB2S:
L3: radius -27 mm (OT envelope shrink) + 2 mm (smaller no-go zone between TB2S and BTL). numRods: -2 rods.
TEDD:
All radii are changed, following the compression from the innermost and outermost rings (intermediate rings were adjusted accordingly).
Number of modules: 4 modules less in Ring 7 and 4 modules less in Ring 14 in TEDD_2.
TBPS:
L1: +2 mm in last 5 rings radii.
Off-topic:
Also increased disk separation in TEDD + Adjusted planck thickness, flipped alternation of outer / inner radii in TBPS.

Inner Tracker:
New chip size everywhere.
Adjustments in radii.
New ring paradigm in TEPX (tested on CMMSW by Arash Jofrehei).
2x2 modules in TEPX inner rings.

FYI: @boudoul (Credits here, happily took ideas from your PRs :)) @alkemyst @pwittich

…cker T14 (scenario D40).

…d workflows for D40 geometry scenario. Made workflow numbering invariant.

cmsbuild · 2019-02-20T20:54:02Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-02-20T20:58:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25988/8501

This PR adds an extra 180KB to repository

cmsbuild · 2019-02-20T20:59:07Z

A new Pull Request was created by @ghugo83 for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerRecoData
SLHCUpgradeSimulations/Geometry

@pgunnell, @prebello, @Dr15Jones, @cvuosalo, @civanch, @ianna, @kpedro88, @cmsbuild, @franzoni, @mdhildreth, @zhenhu, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

ghugo83 · 2019-02-20T21:02:14Z

I avoided a shift in workflow numbering in https://github.com/cms-sw/cmssw/pull/25988/files#diff-0b98ab5f4c0e35c17624487441dbab08R66
FYI: @boudoul

kpedro88 · 2019-02-20T22:36:12Z

thanks @ghugo83! (Net reduction of 1, at least...)

boudoul · 2019-02-21T07:58:10Z

Hello @kpedro88 what is the plan for the geometries for the L1 TDR - What is the scenario intended to be used ?

emiglior · 2019-02-21T08:17:32Z

@jalimena this is of interest for you as well

kpedro88 · 2019-02-21T15:07:55Z

@boudoul I think we will start from D35 (used for MTD TDR) and attempt to incorporate some upcoming HGCal geometry updates, if they are ready in time
@rekovic do you have anything to add?

civanch · 2019-02-21T23:24:49Z

please test

cmsbuild · 2019-02-21T23:25:16Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33216/console Started: 2019/02/22 00:26

cmsbuild · 2019-02-22T01:03:29Z

+1
Tested at: 1500417
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25988/33216/summary.html

cmsbuild · 2019-02-26T18:20:58Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25988/33295/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25988/28634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D40_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D40+RecoFullGlobal_2023D40+HARVESTFullGlobal_2023D40

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3098286
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3098088
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

cvuosalo · 2019-02-27T16:40:17Z

+1

kpedro88 · 2019-02-28T17:23:07Z

+upgrade

fabiocos · 2019-03-03T18:07:39Z

@ghugo83 @emiglior @boudoul @kpedro88 I understand that the removed scenarios were just test ones not used in any production, am I correct?

fabiocos · 2019-03-03T18:08:38Z

+operations

the updated to Configuration is coherent with the purpose of the PR

emiglior · 2019-03-04T11:18:52Z

@ghugo83 @emiglior @boudoul @kpedro88 I understand that the removed scenarios were just test ones not used in any production, am I correct?

@fabiocos Indeed T7 and T8 were used for only tests.
To my recollection the tracker geometries used for productions are:

T5 -> phase2 Tracker TDR
T6 -> MTD TDR

zhenhu · 2019-03-04T16:59:15Z

+1

cmsbuild · 2019-03-04T16:59:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-03-04T17:29:13Z

+1

boudoul · 2019-03-05T13:09:46Z

@boudoul I think we will start from D35 (used for MTD TDR) and attempt to incorporate some upcoming HGCal geometry updates, if they are ready in time
@rekovic do you have anything to add?

Dear @kpedro88 we just discuss at the XEB that the scenario with the new HGCAL preapred by @bsunanda should include the tracker T14 for the L1 TDR prod , so this scenario should be prepared... I'm adding @fabiocos to inform him prior the ORP (that I may missed today ) -
@venturia , thank you for providing the name of the tracker to be used.

kpedro88 · 2019-03-05T14:48:45Z

@boudoul thanks for the update, let me open an issue to keep track

kpedro88 · 2019-03-05T14:54:45Z

see #26071

boudoul · 2019-03-05T15:06:21Z

Perfect , thanks @kpedro88 !

ghugo83 added 3 commits February 20, 2019 19:00

Add XMLs for OT_616 + IT_613 Tracker

eb87a0a

Remove Trackers T7 + T8 (scenarios D22 and D23 respectively). Add Tra…

eb6bb9c

…cker T14 (scenario D40).

Remove all workflows associated to D22 and D23 geometry scenarios. Ad…

1500417

…d workflows for D40 geometry scenario. Made workflow numbering invariant.

cmsbuild added this to the CMSSW_10_5_X milestone Feb 20, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Feb 20, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 20, 2019

smuzaffar modified the milestones: CMSSW_10_5_X, CMSSW_10_6_X Feb 21, 2019

cmsbuild added tests-started and removed tests-pending labels Feb 21, 2019

cmsbuild added the tests-approved label Feb 26, 2019

cmsbuild added comparison-available and removed comparison-pending labels Feb 26, 2019

cmsbuild added geometry-approved and removed geometry-pending labels Feb 27, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels Feb 28, 2019

cmsbuild added operations-approved and removed operations-pending labels Mar 3, 2019

cmsbuild added fully-signed pdmv-approved and removed pdmv-pending pending-signatures labels Mar 4, 2019

cmsbuild added orp-approved and removed orp-pending labels Mar 4, 2019

cmsbuild merged commit b54a7b1 into cms-sw:master Mar 4, 2019

kpedro88 mentioned this pull request Mar 5, 2019

Phase 2 geometry updates for L1 TDR #26071

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase 2 Trackers. Remove T7 and T8 (IT large pixels study). Add T14 (New OT envelope + Numerous updates in IT). #25988

Phase 2 Trackers. Remove T7 and T8 (IT large pixels study). Add T14 (New OT envelope + Numerous updates in IT). #25988

ghugo83 commented Feb 20, 2019 •

edited

cmsbuild commented Feb 20, 2019

cmsbuild commented Feb 20, 2019

cmsbuild commented Feb 20, 2019

ghugo83 commented Feb 20, 2019 •

edited

kpedro88 commented Feb 20, 2019

boudoul commented Feb 21, 2019

emiglior commented Feb 21, 2019

kpedro88 commented Feb 21, 2019

civanch commented Feb 21, 2019

cmsbuild commented Feb 21, 2019 •

edited

cmsbuild commented Feb 22, 2019

cmsbuild commented Feb 26, 2019

cvuosalo commented Feb 27, 2019

kpedro88 commented Feb 28, 2019

fabiocos commented Mar 3, 2019

fabiocos commented Mar 3, 2019

emiglior commented Mar 4, 2019

zhenhu commented Mar 4, 2019

cmsbuild commented Mar 4, 2019

fabiocos commented Mar 4, 2019

boudoul commented Mar 5, 2019

kpedro88 commented Mar 5, 2019

kpedro88 commented Mar 5, 2019

boudoul commented Mar 5, 2019

Phase 2 Trackers. Remove T7 and T8 (IT large pixels study). Add T14 (New OT envelope + Numerous updates in IT). #25988

Phase 2 Trackers. Remove T7 and T8 (IT large pixels study). Add T14 (New OT envelope + Numerous updates in IT). #25988

Conversation

ghugo83 commented Feb 20, 2019 • edited

cmsbuild commented Feb 20, 2019

cmsbuild commented Feb 20, 2019

cmsbuild commented Feb 20, 2019

ghugo83 commented Feb 20, 2019 • edited

kpedro88 commented Feb 20, 2019

boudoul commented Feb 21, 2019

emiglior commented Feb 21, 2019

kpedro88 commented Feb 21, 2019

civanch commented Feb 21, 2019

cmsbuild commented Feb 21, 2019 • edited

cmsbuild commented Feb 22, 2019

cmsbuild commented Feb 26, 2019

cvuosalo commented Feb 27, 2019

kpedro88 commented Feb 28, 2019

fabiocos commented Mar 3, 2019

fabiocos commented Mar 3, 2019

emiglior commented Mar 4, 2019

zhenhu commented Mar 4, 2019

cmsbuild commented Mar 4, 2019

fabiocos commented Mar 4, 2019

boudoul commented Mar 5, 2019

kpedro88 commented Mar 5, 2019

kpedro88 commented Mar 5, 2019

boudoul commented Mar 5, 2019

ghugo83 commented Feb 20, 2019 •

edited

ghugo83 commented Feb 20, 2019 •

edited

cmsbuild commented Feb 21, 2019 •

edited