Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[105X] removing three fragments from override (backport of #25955) #25997

Merged
merged 4 commits into from Feb 25, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Feb 22, 2019

This PR is made to fix DAS errors in 250204.18,10826.0,10001.0 during pre2 build tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_5_X.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

code-checks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25997/8515

  • This PR adds an extra 44KB to repository

@fabiocos
Copy link
Contributor Author

please test workflow 250204.18,10826.0,10001.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33224/console Started: 2019/02/22 09:59

@cmsbuild
Copy link
Contributor

-1

Tested at: d4d8624

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25997/33224/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@prebello
Copy link
Contributor

please test workflow 250204.18,10826.0,10001.0

Hi @fabiocos the error is not related to the PR but file open error at FNAL, right?
The root file mentioned in the summary is in DAS at FNAL disk so I guess it was a temporary issue. Maybe request other test would work.
/store/relval/CMSSW_10_5_0_pre1/RelValMinBias_13/GEN-SIM/103X_mc2017_realistic_v2-v1/20000/ACB3CEC8-09F0-174B-AD93-84BA32EED0C5.root

FYI @zhenhu @pgunnell

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33230/console Started: 2019/02/22 16:12

@fabiocos
Copy link
Contributor Author

@prebello this problem seems to affect also other PR tests...

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25997/33230/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25997/10001.0_SingleElectronPt10+SingleElectronPt10_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25997/250204.18_QQH1352T_13UP18+QQH1352T_13UP18+DIGIPRMXUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3098286
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3098088
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@prebello
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor Author

+1

@kpedro88 this is not upgrade specific, and it works in 10_6_X, I let you approve it for merge

@kpedro88
Copy link
Contributor

backport of #25955

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit c3458c5 into cms-sw:CMSSW_10_5_X Feb 25, 2019
@fabiocos fabiocos deleted the fc-bp25955 branch February 28, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants