Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to include all Muons #2600

Merged
merged 4 commits into from Feb 23, 2014
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Feb 23, 2014

  • RPC upgrade with 2.4 eta and 192 strips

@ianna
Copy link
Contributor Author

ianna commented Feb 23, 2014

@davidlange6 - Please, take this one for SLHC8

@ianna
Copy link
Contributor Author

ianna commented Feb 23, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@ianna
Copy link
Contributor Author

ianna commented Feb 23, 2014

+1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC.

Corrections to include all Muons

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #2600 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #2600 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Feb 23, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12400 and 12600 pass.
12200 (Extended2023HGCalMuon) fails with "unable to find file Geometry/MuonSimData/data/PhaseII/v4/muonSens.xml anywhere in the search path". My release only has "v2" and "v3" directories in PhaseII.
@ianna do you still want this in and 12200 can be fixed later?

@mark-grimes
Copy link

merge

12200 can be fixed later.

cmsbuild added a commit that referenced this pull request Feb 23, 2014
Corrections to include all Muons
@cmsbuild cmsbuild merged commit 33fa18e into cms-sw:CMSSW_6_2_X_SLHC Feb 23, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
adding histogrammar package (try2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants