Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenarios for slhc8 #2601

Merged
merged 4 commits into from Feb 24, 2014
Merged

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Feb 23, 2014

update the sequence for the different scenarios

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC.

Scenarios for slhc8

It involves the following packages:

Configuration/PyReleaseValidation
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

All tests fail with

  File "/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/python/SLHCUpgradeSimulations/Configuration/combinedCustoms.py", line 20, in <module>
    from SLHCUpgradeSimulations.Configuration.gemCustoms import customise_ValidationNoGem_2023 as CustomiseValidation_NoGem_2023
ImportError: cannot import name customise_ValidationNoGem_2023

Should gemCustoms.py be part of this pull request?

@boudoul
Copy link
Contributor Author

boudoul commented Feb 24, 2014

Indeed ... Sorry I forgot gemCustoms.py in my PR :(

@cmsbuild
Copy link
Contributor

Pull request #2601 was updated. @civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #2601 was updated. @civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please check and sign again.

@mark-grimes
Copy link

merge

10000,10200,10400,11200,11400,11600,11800,12000 pass all steps. The following fail, but they are either completely new or have additional steps added.
12200, 12400, 12600 fail in step 2. 12800 and 13000 fail in step 1. It looks like Ianna's requests will fix some of these.

cmsbuild added a commit that referenced this pull request Feb 24, 2014
@cmsbuild cmsbuild merged commit e45375b into cms-sw:CMSSW_6_2_X_SLHC Feb 24, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Updated root to tip 7c45c0d of root 6-06-patches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants