Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.2.X Added links from LowPtGsf to PackedCandidates and LostTracks in MiniAOD #26036

Merged
merged 2 commits into from Mar 5, 2019

Conversation

mverzett
Copy link
Contributor

Verbatim backport of #26031

@bainbrid is interested in following this

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mverzett (Mauro Verzetti) for CMSSW_10_2_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @perrotta, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2019

Please synchronize the changes in this backport with the latest additions in #26031

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

Pull request #26036 was updated. @cmsbuild, @perrotta, @santocch, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Mar 4, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33381/console Started: 2019/03/04 11:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26036/33381/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007209
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Mar 4, 2019

+1

  • Exact backport of Added links from LowPtGsf to PackedCandidates and LostTracks in MiniAOD #26031, now merged in the master
  • The new maps only add up to the miniAOD output when the bParking era is set: jenkins tests pass and show no differences
  • As in the master, there is a check to be done on the lowPtElectron code which jumps from time to time on some all 0 parameters tracks: this is independent from this PR, however, which can be therefore integrated while that issue is getting dedugged

@santocch
Copy link

santocch commented Mar 5, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 5, 2019

+1

@cmsbuild cmsbuild merged commit 9d32b2b into cms-sw:CMSSW_10_2_X Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants