Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relval for b parking skim 102x #26038

Merged

Conversation

kfjack
Copy link
Contributor

@kfjack kfjack commented Mar 1, 2019

Back port of bparking skim to 102X + adding relval tests.
Merging the files/updates from PR #25995, PR #25892, and PR #26035

Workflow 136.898 to be tested.

@gkaratha and @bainbrid --- this should replace PR #25995.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

A new Pull Request was created by @kfjack (Kai-Feng Chen) for CMSSW_10_2_X.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/Skimming

@cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Mar 1, 2019

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26038/8579

  • This PR adds an extra 60KB to repository

@fabiocos
Copy link
Contributor

fabiocos commented Mar 1, 2019

please test workflow 136.898,136.8501,10824.8

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33351/console Started: 2019/03/01 14:40

@fabiocos
Copy link
Contributor

fabiocos commented Mar 1, 2019

apart for spaces it is fully consistent with my test backport https://github.com/fabiocos/cmssw/tree/fc-bp26035

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26038/33351/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26038/10824.8_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_ParkingBPH_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26038/136.8501_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimParkingBPH_Prompt+HARVEST2018
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26038/136.898_RunParkingBPH2018B+RunParkingBPH2018B+HLTDR2_2018+RECODR2_2018reHLT_skimParkingBPH_Prompt+HARVEST2018

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007206
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@kfjack
Copy link
Contributor Author

kfjack commented Mar 2, 2019

Hi all, I think the B parking skim part looks okay technically.

Could @gkaratha and @bainbrid double check the contents?
The files are available at https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26038/33351/runTheMatrix-results/136.898_RunParkingBPH2018B+RunParkingBPH2018B+HLTDR2_2018+RECODR2_2018reHLT_skimParkingBPH_Prompt+HARVEST2018/
Many thanks.

@gkaratha
Copy link
Contributor

gkaratha commented Mar 2, 2019

Dear @kfjack ,

Thanks for your help! I appreciated. I checked the file like last time and it runs fine[*].Thanks again.

Best regards,
George

[*] TrigReport Events total = 8 passed = 4 failed = 4

@kfjack
Copy link
Contributor Author

kfjack commented Mar 4, 2019

Hi all, I think this PR is fine and we can merge if it is also okay for everyone. Many thanks.

@prebello
Copy link
Contributor

prebello commented Mar 4, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Mar 5, 2019

@kpedro88 this is not strictly upgrade specific, anyway please have a look and sign it in case. I would like to merge it for next IB at this point, if no problem is seen in master for #26035 (as I expect)

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 5, 2019

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 5, 2019

+1

@cmsbuild cmsbuild merged commit c215e4e into cms-sw:CMSSW_10_2_X Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants