Fix CaloParticle Debugger

[rovere]

Adapt the CaloParticle debugger code to handle also TDR geometries of
HGCAL.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26066/8623

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

SimGeneral/Debugging

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33417/console Started: 2019/03/05 17:43

[cmsbuild]

-1

Tested at: 1d75bb9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26066/33417/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found compilation warning when building: See details on the summary page.

• Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

+ eval scram build outputlog '&&' '(/build/cmsbld/jenkins/workspace/ib-any-integration/cms-bot/buildLogAnalyzer.py' --logDir /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-04-2300/tmp/slc7_amd64_gcc700/cache/log/src '||' 'true)'
++ scram build outputlog
Reading cached build data
Entering library rule at src/SimGeneral/Debugging/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-04-2300/src/SimGeneral/Debugging/plugins/CaloParticleDebugger.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-04-2300/src/SimGeneral/Debugging/plugins/CaloParticleDebugger.cc:313:17: error: array index 2 is past the end of the array (which contains 2 elements) [-Werror,-Warray-bounds]
  if(bhgeomnew) hgtopo[2] = &(bhgeomnew->topology());
                ^      ~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-04-2300/src/SimGeneral/Debugging/plugins/CaloParticleDebugger.cc:296:3: note: array 'hgtopo' declared here
  const HGCalTopology*     hgtopo[2];
  ^


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[rovere]

I doubt that those errors are in any way related to this PR. I saw them also in other PR. Could someone please re-trigger the tests?

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33506/console Started: 2019/03/10 19:06

[cmsbuild]

+1
Tested at: b45e6aa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26066/33506/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26066/33506/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114631
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1