Phase2-hgx181 First step of making v10 HGCal geometry

[bsunanda]

This is the post TDR geometry with reduced thickness (in cm as well as in lambda) of HGCal. Also the current partition between barrel and endcap is taken care of, the position of neutron moderator. Current ETL geometry cannot be combined with this - it will be changed soon.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26078/8636

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CMSCommonData
Geometry/EcalCommonData
Geometry/HGCalCommonData
Geometry/HcalCommonData
SimG4CMS/Calo

@civanch, @Dr15Jones, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33426/console Started: 2019/03/06 03:28

[cmsbuild]

+1
Tested at: 81e065c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26078/33426/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26078/33426/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114826
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114628
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

+upgrade

[bsunanda]

@cvuosalo @ianna @civanch Please look into this PR at the earliest. We would like to go forward with the next steps quickly

[bsunanda]

@cvuosalo Kindly approve this PR at the earliest. We need to make the new HGCal geometry available for early testing of background in the muon system

[cvuosalo]

+1

[bsunanda]

@civanch Could you approve this PR

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@bsunanda @kpedro88 in this PR a few xml files used for instance in the production scenario D35 are touched. As far as I can see there is only the addition of a parameter previously not present and not used in the code, and which I understand is supposed to leave the existing scenario untouched. Indeed the PR test shows no difference, although they are just a few events (and I am not sure about the validation coverage of HGCal). Are we sure that the old scenarios are unaffected by the changes to the algorithms?

[bsunanda]

@fabiocos @kpedro88 The earlier scenarios are unaffected by the changes.

[fabiocos]

+1