Fixing MultiIso in muon Selector: Removing the double declaration of the variable "miniIsoValue "

[bmahakud]

MultiIso is based on the values of three variables i.e.
1.) miniIsoValue
2.) muon.jetPtRatio and
3.) muon.jetPtRel() .
If you print values of miniIsoValue at this line

https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/PatAlgos/plugins/PATMuonProducer.cc#L684 it always gives -1.
This is because it has been declared twice
https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/PatAlgos/plugins/PATMuonProducer.cc#L650-L653

So the current mutiIso values that you get in miniAOD is just based on the two variables . 2.) muon.jetPtRatio and 3.) muon.jetPtRel()
So with this bug , the desired performance of MultiIso is not expected at mini AOD.
Fixing this, desired performance will be achieved.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26093/8660

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bmahakud (Bibhuprasad Mahakud) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @perrotta, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33448/console Started: 2019/03/06 23:35

[slava77]

@bmahakud please edit the title say MultiIso (instead of MutiIso)

[cmsbuild]

+1
Tested at: 72cdce7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26093/33448/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26093/33448/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114826
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114628
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

This fixes a clear bug, and definitely up to now the MultiIsoLoose and MultiIsoMedium were wrongly computed.
Both those selectors, and the bug, were introduced since CMSSW_10_1_0 with #22420, almost one year ago. Out of curiosity: were they ever used in analyses?

[drkovalskyi]

Since the bug makes MultiIsoLoose and MultiIsoMedium useless and no one reported this problem earlier, no one really used it so far.

[perrotta]

type bugfix

[perrotta]

+1

• It fixes a bug which makes MultiIsoLoose and MultiIsoMedium selectors wrongly computed, and therefore useless
• Changes in the muon selectors word in miniAOD reflect the effect of this fix on those two selectors

[fabiocos]

@santocch I would move forward with this bug fix

[fabiocos]

+1

[fabiocos]

merge

it looks a clear bug fix

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[fabiocos]

@bmahakud @perrotta @drkovalskyi given the discussion in the thread, I would not consider the backport of this PR as critical for 10_5_0 , although it doesn't harm. Please comment in case

[perrotta]

For sure a backport of this pull request doesn't harm, although I'd see it more conveniently backported into an analysis release (e.g 10_2) rather than into 10_5_X