changes needed for DDUnits to GeantUnits migration

[smuzaffar]

PR description:

This is needed to fix IB build error due to DDUnits to GeantUnits migration

PR validation:

No validation tests were run

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26095/8665

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33452/console Started: 2019/03/07 09:28

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

SimG4CMS/Calo

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

Diagnosis of the problem: the last test of #25967 was done just before the merge of #26023, where a new file is added, using the header file modified in the former. This causes the build to fail for the simulation libraries, and therefore most of the IB failures seen in CMSSW_10_6_X_2019-03-06-2300

[cmsbuild]

+1
Tested at: 7ca09e3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26095/33452/summary.html

[cmsbuild]

Comparison job queued.

[fabiocos]

+1

the problems was technical and looks fixed by this PR

[fabiocos]

merge

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26095/33452/summary.html

There are some workflows for which there are errors in the baseline:
25.0 step 1
8.0 step 1
158.0 step 1
9.0 step 1
7.3 step 1
25202.0 step 1
1330.0 step 1
1306.0 step 1
10024.0 step 1
101.0 step 1
10042.0 step 1
10224.0 step 1
10824.0 step 1
11624.0 step 1
20034.0 step 1
21234.0 step 1
27434.0 step 1
250202.181 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• You potentially added 6297 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 884430
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 884364
• DQMHistoTests: Total skipped: 66
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 72 log files, 4 edm output root files, 15 DQM output files