retain name of script that is fed to cmsRun in pybind11 interface #26097
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26097/8669
|
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FWCore/PyDevParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test
… On Mar 7, 2019, at 2:28 PM, cmsbuild ***@***.***> wrote:
A new Pull Request was created by @davidlange6 (David Lange) for master.
It involves the following packages:
FWCore/PyDevParameterSet
@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.
cms-bot commands are listed here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The tests are being triggered in jenkins. |
|
Does this make for better error messages? |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
core-approved
fully-signed
tests-started
labels
|
I didn't test that intentionally - from my small tests, I believe that it has no impact.
… On Mar 7, 2019, at 3:24 PM, Chris Jones ***@***.***> wrote:
Does this make for better error messages?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26097/8675
|
|
Pull request #26097 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
|
@davidlange6 the regular PR tests are not testing anything here, am I correct? So we could just move forward |
|
+1 |
|
there are unit tests in FWCore/PyDevParameterSet that are testing this change, but none of the standard workflows or other unit tests are affected (aside from in DEVEL).
… On Mar 8, 2019, at 9:18 AM, Fabio Cossutti ***@***.***> wrote:
@davidlange6 the regular PR tests are not testing anything here, am I correct? So we could just move forward
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
PR description:
retain name of script that is fed to cmsRun in pybind11 interface
PR validation:
Fixes unit test failing in DEVEL build in FWCore/Integration package