[HGCal] first version of the HGCalValidator #26099

apsallid · 2019-03-07T13:41:56Z

PR description:

This PRs includes the work done in the context of the HGCal DPG with @rovere, @felicepantaleo.
The work was presented in HGCal DPG [1-3] and adds a package (HGCalValidator) to validate
2D layer clusters ("hgcalLayerClusters"). HGCalValidator follows the MultiTrackValidator package that is used by the
Tracker for validation purposes due its excellent design and sophisticated organisation of the code.

PR validation:

The package follows the MultiTrackValidator desing with HGCalValidator a DQMGlobalEDAnalyzer and
a Histogramming class (HGVHistoProducerAlgo), which books histograms to be stored in the DQM file.
There are also python scripts (hgcalPlots.py,makeHGCalValidationPlots.py) for generating final set
of plots with an option to generate HTML pages.
Furthermore, code has been developed to evaluate the goodness of the layer clustering
(not the (3D) object reconstruction) by establishing links and metrics between CaloParticles and Layer Clusters.

After the harvesting step, you can run the makeHGCalValidationPlots.py script e.g:

makeHGCalValidationPlots.py DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root

Detailed information in these presentations:

[1] https://indico.cern.ch/event/803066/contributions/3341958/attachments/1807341/2950233/20190306_HGCAL_DPG_ImagingAlgoModification_MR.pdf

[2] https://indico.cern.ch/event/800319/contributions/3325657/attachments/1799432/2934489/hgcal_dpg_2_2019.pdf

[3] https://indico.cern.ch/event/800319/contributions/3325660/attachments/1799333/2934293/HGCalValidation_20Feb19_HGCalDPG.pdf

@felicepantaleo @rovere @cseez @malgeri

cmsbuild · 2019-03-07T13:42:25Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-03-07T14:07:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26099/8670

This PR adds an extra 152KB to repository

cmsbuild · 2019-03-07T14:08:22Z

A new Pull Request was created by @apsallid for master.

It involves the following packages:

DataFormats/EgammaReco
RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers
Validation/Configuration
Validation/HGCalValidation

@perrotta, @andrius-k, @kmaeshima, @schneiml, @civanch, @kpedro88, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @mdhildreth can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @Sam-Harper, @sethzenz, @felicepantaleo, @jainshilpi, @rovere, @lgray, @cseez, @bsunanda, @pfs, @argiro, @varuns23, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

andrius-k · 2019-03-07T15:37:27Z

please test

cmsbuild · 2019-03-07T15:37:58Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33460/console Started: 2019/03/07 16:39

kpedro88 · 2019-03-07T16:22:21Z

RecoLocalCalo/HGCalRecAlgos/src/HGCalImagingAlgo.cc

@@ -668,3 +675,20 @@ void HGCalImagingAlgo::computeThreshold() {
  }

 }
+
+void HGCalImagingAlgo::setDensity(std::vector<KDNode> &nd){


input can be const

kpedro88 · 2019-03-07T16:23:09Z

RecoLocalCalo/HGCalRecAlgos/interface/HGCalImagingAlgo.h

@@ -195,6 +213,9 @@ hgcal::RecHitTools rhtools_;
 // The algo id
 reco::CaloCluster::AlgoId algoId_;

+// For keeping the density per hit
+ std::map< DetId, float > density_v;


use typedef here

kpedro88 · 2019-03-07T16:23:42Z

RecoLocalCalo/HGCalRecProducers/plugins/HGCalLayerClusterProducer.cc

@@ -168,7 +170,8 @@ void HGCalLayerClusterProducer::produce(edm::Event& evt,

  std::unique_ptr<std::vector<reco::BasicCluster> > clusters( new std::vector<reco::BasicCluster> ),
    clusters_sharing( new std::vector<reco::BasicCluster> );
-
+  std::unique_ptr<Density> density(new Density);


make_unique (don't use new)

kpedro88 · 2019-03-07T16:24:50Z

Validation/HGCalValidation/python/HGCalValidator_cfi.py

+    #The cumulative material budget in front of each layer. To be more specific, it 
+    #is the material budget just in front of the active material (not including it). 
+    #This file is created using the official material budget code. 
+    cummatbudinxo = cms.FileInPath('Validation/HGCalValidation/data/D28.cumulative.xo'),


it's going to be difficult to keep this manually in sync with all the different 2023 geometry versions...

Yes, you are right, but could we please keep this? Upon request and on specific geometry versions I could produce the
relevant file. It is that in previous beam tests they have used the longitudinal depth barycentre (which uses this file), while it
would be nice to connect the material budget package with the validation package.

Will this code be run by default for any phase 2 workflow? What will happen if this is run on a geometry with a different material budget?

The longitudinal depth barycentre plot will be wrong. This one here.

This is the only usage of the file currently, that is to produce that plot. Specifically, a std::map<double, double> cummatbudg -> (layer, accumulatedmaterialbudgetuptothatlayer)
is filled by that file. Then, at the core of the code, layer number is accessed as usual like:

layer = recHitTools_->getLayerWithOffset(rh_detid);

So, since this is a map even if the key doesn't exist, it shouldn't crash, right?

I'm more worried about getting wrong/nonsensical results out of the validation code. If this is acceptable to the people doing HGCal validation, we can continue in this way, but in practice it will probably mean the validation code is frequently out of sync with the latest version of the geometry.

Ok, if you think it would bring confusion I can remove that plot, the file, the data directory that was created for that reason and any relevant code. In other case, I can add to the title of the plot I sent you before something like "always check that you read the correct material budget file". What do you think?

For me, a title message like that would be fine. I would specify in the title message which material budget file was used, so an observer does not have to dig through to find the python config.

kpedro88 · 2019-03-07T16:25:20Z

Validation/HGCalValidation/python/HGVHistoProducerAlgoBlock_cfi.py

+    minCellsEneDensperthick = cms.double(0.),
+    maxCellsEneDensperthick = cms.double(100.),
+    nintCellsEneDensperthick = cms.int32(200)
+


remove unneeded blank lines

kpedro88 · 2019-03-07T16:33:02Z

Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h

+ */
+
+#include <iostream>
+#include <fstream>


#include <vector> #include <unordered_map>

kpedro88 · 2019-03-07T16:35:55Z

Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h

+//  std::map<DetId, const HGCRecHit *> * hitMap_;
+
+  //private data members
+  double minEta, maxEta;  int nintEta; bool useFabsEta;


member variables should end with "_"

kpedro88 · 2019-03-07T16:37:53Z

Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc

+      DetId rh_detid = hits_and_fractions[i].first;
+      float rhFraction = hits_and_fractions[i].second;
+      bool hitWithNoCP = false;
+//      if(rhFraction ==0) continue;


delete commented-out code

kpedro88 · 2019-03-07T16:38:32Z

Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc

+    auto assoc = std::count_if(
+        std::begin(cpsInLayerCluster[lcId]),
+        std::end(cpsInLayerCluster[lcId]),
+        [](const auto &obj){return obj.second < 0.2;});


magic number should be named constant

kpedro88 · 2019-03-07T16:39:13Z

Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc

+      	continue;
+      }
+
+      // thickness = (rh_detid.det() == DetId::Forward || rh_detid.det() == DetId::HGCalEE || rh_detid.det() == DetId::HGCalHSi) ? recHitTools_->getSiThickness(rh_detid) : -1;


remove commented-out code

cmsbuild · 2019-03-07T17:19:13Z

-1

Tested at: 0bec981

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26099/33460/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

9.0 step1

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step1

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

7.3 step1

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step1_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

158.0 step1

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step1_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

1306.0 step1

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step1

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM/step1_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM.log

25202.0 step1

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step1_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10024.0 step1

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

10224.0 step1

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

10042.0 step1

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step1_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

10824.0 step1

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

11624.0 step1

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019/step1_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019.log

21234.0 step1

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

20034.0 step1

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

250202.181 step1

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35.log

27434.0 step1

runTheMatrix-results/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Thu Mar 7 18:08:44 2019-date Thu Mar 7 18:00:20 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-03-06-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Mar 7 18:08:44 2019-date Thu Mar 7 18:00:20 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Mar 7 18:08:44 2019-date Thu Mar 7 18:00:20 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Thu Mar 7 18:05:36 2019-date Thu Mar 7 18:00:29 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-03-06-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Mar 7 18:05:36 2019-date Thu Mar 7 18:00:29 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Mar 7 18:05:36 2019-date Thu Mar 7 18:00:29 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Thu Mar 7 18:05:31 2019-date Thu Mar 7 18:00:37 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-03-06-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Mar 7 18:05:31 2019-date Thu Mar 7 18:00:37 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Thu Mar 7 18:05:31 2019-date Thu Mar 7 18:00:37 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018_pp_on_AA --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Thu Mar 7 18:06:51 2019-date Thu Mar 7 18:00:39 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-03-06-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Mar 7 18:06:51 2019-date Thu Mar 7 18:00:39 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018_pp_on_AA --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Thu Mar 7 18:06:51 2019-date Thu Mar 7 18:00:39 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_MC.root : FAILED - time: date Thu Mar 7 18:05:37 2019-date Thu Mar 7 18:00:40 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-03-06-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Mar 7 18:05:37 2019-date Thu Mar 7 18:00:40 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Thu Mar 7 18:05:37 2019-date Thu Mar 7 18:00:40 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Thu Mar 7 18:05:37 2019-date Thu Mar 7 18:00:41 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-03-06-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Mar 7 18:05:37 2019-date Thu Mar 7 18:00:41 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Thu Mar 7 18:05:37 2019-date Thu Mar 7 18:00:41 2019 s - exit: 21504
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Thu Mar 7 18:05:55 2019-date Thu Mar 7 18:00:55 2019 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-03-06-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Mar 7 18:05:55 2019-date Thu Mar 7 18:00:55 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Mar 7 18:05:55 2019-date Thu Mar 7 18:00:55 2019 s - exit: 21504

cmsbuild · 2019-03-07T17:19:17Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

slava77 · 2019-03-07T21:09:49Z

Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc

+    float totalCPEnergyOnLayer = 0.f;
+    if(maxCPId_byEnergy >=0) {
+      totalCPEnergyOnLayer = cPOnLayer[maxCPId_byEnergy][lcLayerId].energy;
+      energyFractionOfCPinLC = maxEnergySharedLCandCP/totalCPEnergyOnLayer;


this line generates a warning in the static analyzer
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26099/33460/llvm-analysis/report-b756de.html#EndPath

There are 4 more https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26099/33460/llvm-analysis/

It seems that setting and using these variables only for couts produces these warnings. We would like to leave the information in the code in order to use it when we will need it for debugging purposes, if this is not a big problem.

cmsbuild · 2019-03-24T21:15:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26099/33735/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3114829
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3114631
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 121650.294 KiB( 31 files compared)
DQMHistoSizes: changed ( 27434.0,... ): 40550.098 KiB HGCAL/HGCalValidator
Checked 133 log files, 14 edm output root files, 32 DQM output files

perrotta · 2019-03-25T10:14:23Z

+1

Already signed by reco, the most recent changes since [HGCal] first version of the HGCalValidator #26099 (comment) only affect Validation

kpedro88 · 2019-03-25T10:24:54Z

+upgrade

perrotta · 2019-03-25T14:33:34Z

@jfernan2,@andrius-k,@schneiml,@kmaeshima
@civanch,@mdhildreth
Could you please evaluate and sign (if you think so) or provide comments to this PR? There is another HGCal PR queued, #26194, which is depending on this one

andrius-k · 2019-03-26T09:43:14Z

+1

civanch · 2019-03-26T16:39:53Z

+1

cmsbuild · 2019-03-26T16:40:25Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-03-27T17:06:32Z

running workflow 29034.0 (scenario D41 with the latest V10 HGCal geometry) I get by dqmMemoryStats an addition of ~ 40MB to the DQM output (as for D35 seen above):

18:05 cmsdev25 2857> diff -b CMSSW_10_6_X_2019-03-27-1100/work/29034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41/dqm std/CMSSW_10_6_X_2019-03-27-1100/work/29034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41/dqm
6d5
< 40550.10 KiB     HGCAL/HGCalValidator
52c51
< Total bytes: 669617.21 KiB
---
> Total bytes: 629067.11 KiB

rovere · 2019-03-27T19:49:37Z

@fabiocos Indeed that's correct. Keep in mind, though, that we exclusively used ConcurrentMonitorElements, so this number will not be multiplied by the number of streams in the process.
We will eventually shut down a bunch of them in the long run, but in this intense phase of development we would like to have them all in.
Let us know if you think that's possible.

fabiocos · 2019-03-27T21:13:05Z

+1

cmsbuild added this to the CMSSW_10_6_X milestone Mar 7, 2019

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Mar 7, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 7, 2019

apsallid force-pushed the hgcalvalidator branch from fb29111 to 0bec981 Compare March 7, 2019 14:14

apsallid mentioned this pull request Mar 7, 2019

[HGCal] Modify MultiTrackValidator plotting for easier browsing of HGCal plots #26100

Merged

cmsbuild added tests-started and removed tests-pending labels Mar 7, 2019

kpedro88 reviewed Mar 7, 2019

View reviewed changes

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Mar 7, 2019

slava77 reviewed Mar 7, 2019

View reviewed changes

cmsbuild removed the code-checks-approved label Mar 8, 2019

cmsbuild added tests-approved and removed tests-started labels Mar 24, 2019

cmsbuild added comparison-available and removed comparison-pending labels Mar 24, 2019

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 25, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels Mar 25, 2019

cmsbuild added dqm-approved and removed dqm-pending labels Mar 26, 2019

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Mar 26, 2019

cmsbuild added orp-approved and removed orp-pending labels Mar 27, 2019

cmsbuild merged commit 4e3aef7 into cms-sw:master Mar 27, 2019

This was referenced Mar 28, 2019

Add python3 compatible print management in Validation/HGCalValidation #26279

Merged

Crash in wf 20234.99, HGCal validation for Premixing test #26284

Closed

Fix HGCalValidator configuration for premixing #26287

Merged

[HGCal] first version of the HGCalValidator #26099

[HGCal] first version of the HGCalValidator #26099

Conversation

apsallid commented Mar 7, 2019 • edited

PR description:

PR validation:

cmsbuild commented Mar 7, 2019

cmsbuild commented Mar 7, 2019

cmsbuild commented Mar 7, 2019

andrius-k commented Mar 7, 2019

cmsbuild commented Mar 7, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Mar 7, 2019

cmsbuild commented Mar 7, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Mar 24, 2019

perrotta commented Mar 25, 2019

kpedro88 commented Mar 25, 2019

perrotta commented Mar 25, 2019

andrius-k commented Mar 26, 2019

civanch commented Mar 26, 2019

cmsbuild commented Mar 26, 2019

fabiocos commented Mar 27, 2019

rovere commented Mar 27, 2019

fabiocos commented Mar 27, 2019

apsallid commented Mar 7, 2019 •

edited

cmsbuild commented Mar 7, 2019 •

edited