Remove FWCore/Framework dependency from AssociativeIterator

[Dr15Jones]

PR description:

DataFormats/Common should not depend on FWCore/Framework, even just via a header file. Changed the direct dependency to instead be a template parameter. This also allows fwlite::Event to work with the class.
Created makeAssociativeIterator to make it easy to deduce the necessary template arguments for the class.

PR validation:

The code compiles.

[Dr15Jones]

The problem was found by the QA tool Ignominy as a package circular dependency.

[Dr15Jones]

ping

[Dr15Jones]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26156/8745

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/Common
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@perrotta, @smuzaffar, @Dr15Jones, @cmsbuild, @slava77, @santocch can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @ahinzmann, @seemasharmafnal, @mmarionncern, @imarches, @makortel, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @wddgit, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33545/console Started: 2019/03/12 17:01

[Dr15Jones]

+1

[cmsbuild]

+1
Tested at: fd16fee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26156/33545/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
defc586
c19a5d8
7bbacb1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26156/33545/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26156/33545/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26156/33545/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114631
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #26156 fd16fee

• technical
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1