[10.6.X][SIM] fix for clang warnings: SimG4CMS/Forward

[smuzaffar]

PR description:

This fixes clang warnings for SimG4CMS/Forward packages

PR validation:

Local build based on clang IBs shows no more warnings

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26166/8760

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33569/console Started: 2019/03/13 14:35

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

SimG4CMS/Forward

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 911f5f0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26166/33569/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1313262
40d2157
636ce88
ac146f1
821cba0
2ec70ea
35678a3
defc586
c19a5d8
7bbacb1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26166/33569/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26166/33569/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26166/33569/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5012 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 720
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3113910
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 31 files compared)
• DQMHistoSizes: changed ( 136.85 ): 0.004 KiB JetMET/SUSYDQM
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1
differences are in data , not in simulation

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33598/console Started: 2019/03/14 22:57

[cmsbuild]

+1
Tested at: 911f5f0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26166/33598/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26166/33598/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114631
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1

I verified that in the MTD flow the TimingSD::update method was anyway called as desired