Revert default tracking classifier back to BDT for Phase1 (set in PR21717) #26199

hajohajo · 2019-03-16T08:50:47Z

Revert default tracking classifier back to BDT for Phase1. Added new process modifier trackdnn, that can be used to change the tracking classifier to DNN.

@slava77 @mtosi

cmsbuild · 2019-03-16T08:51:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-03-16T08:57:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26199/8797

This PR adds an extra 44KB to repository

cmsbuild · 2019-03-16T08:59:03Z

A new Pull Request was created by @hajohajo for master.

It involves the following packages:

Configuration/ProcessModifiers
RecoTracker/IterativeTracking

@perrotta, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2019-03-16T14:01:34Z

please test

cmsbuild · 2019-03-16T14:03:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33627/console Started: 2019/03/16 15:03

cmsbuild · 2019-03-16T14:52:50Z

-1

Tested at: bde2321

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26199/33627/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

136.8311 step2

runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

8.0 step4

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step4_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

7.3 step3

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

136.85 step3

runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM.log

11624.0 step3

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

27434.0 step3

runTheMatrix-results/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Sat Mar 16 15:39:56 2019-date Sat Mar 16 15:39:46 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:43:18 2019-date Sat Mar 16 15:39:52 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:45:20 2019-date Sat Mar 16 15:39:53 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018_pp_on_AA --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:47:12 2019-date Sat Mar 16 15:39:54 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:51:11 2019-date Sat Mar 16 15:39:59 2019 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Sat Mar 16 15:40:13 2019-date Sat Mar 16 15:40:02 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:47:13 2019-date Sat Mar 16 15:40:05 2019 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Sat Mar 16 15:40:21 2019-date Sat Mar 16 15:40:09 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:45:43 2019-date Sat Mar 16 15:40:14 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:46:44 2019-date Sat Mar 16 15:40:15 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018_pp_on_AA --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:49:03 2019-date Sat Mar 16 15:40:18 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:47:01 2019-date Sat Mar 16 15:40:23 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:48:56 2019-date Sat Mar 16 15:40:24 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:44:58 2019-date Sat Mar 16 15:40:32 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:51:09 2019-date Sat Mar 16 15:40:34 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:46:00 2019-date Sat Mar 16 15:40:38 2019 s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Sat Mar 16 15:48:34 2019-date Sat Mar 16 15:40:40 2019 s - exit: 256

cmsbuild · 2019-03-16T14:52:54Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

slava77 · 2019-03-16T15:27:27Z

RecoTracker/IterativeTracking/python/DetachedQuadStep_cff.py

@@ -2,6 +2,9 @@
 import RecoTracker.IterativeTracking.iterativeTkConfig as _cfg
 from Configuration.Eras.Modifier_fastSim_cff import fastSim

+#for dnn classifier
+from Configuration.ProcessModifiers.trackdnn import trackdnn


_cff is missing

Sorry. Fixed those, and a few other apparent bugs I ran into (wrong track collection in LowPtTripletStep DNN, missing imports for trackSelectionLwtnn_cfi).

cmsbuild · 2019-03-27T08:43:23Z

Comparison job queued.

cmsbuild · 2019-03-27T11:11:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26199/33789/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 11572 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3114829
DQMHistoTests: Total failures: 19494
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3095132
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.008 KiB( 31 files compared)
DQMHistoSizes: changed ( 136.85 ): 0.008 KiB JetMET/SUSYDQM
Checked 133 log files, 14 edm output root files, 32 DQM output files

slava77

I didn't find any issues to be fixed in this PR.
I'm noting two bugfixes for the highBetaStar_2018, which are resolved with the latest changes in this PR.

slava77 · 2019-03-27T20:30:33Z

RecoTracker/IterativeTracking/python/LowPtQuadStep_cff.py

-    qualityCuts = [-0.9, -0.4, 0.3],
-    mva = dict(GBRForestLabel = 'HIMVASelectorLowPtQuadStep_Phase1')
-))
+highBetaStar_2018.toModify(lowPtQuadStep,qualityCuts = [-0.9,-0.35,-0.15])


for future refs: this "simplification" also fixes a bug introduced in #21717 where DetachedTripletStep was passed incorrectly in this highBetaStar iter modifier.

slava77 · 2019-03-27T20:31:58Z

RecoTracker/IterativeTracking/python/HighPtTripletStep_cff.py

-     src = 'highPtTripletStepTracks',
-     mva = dict(GBRForestLabel = 'HIMVASelectorHighPtTripletStep_Phase1')
-))
+highBetaStar_2018.toModify(highPtTripletStep,qualityCuts = [-0.2,0.3,0.4])


for future refs: this "simplification" also fixes a bug introduced in #21717 where DetachedTripletStep mva was passed incorrectly in this highBetaStar iter modifier.

slava77 · 2019-03-27T20:38:51Z

+1

for #26199 a1a8cbf

code changes recover pre-DNN tracking configurations and also allow to pick up the new DNN for tests with a trackdnn modifier
jenkins tests pass and comparisons with the baseline show differences only in workflows running phase-1 tracking where the DNN track classification was introduced earlier and is now reverted
I checked in the expanded configurations that the phase-1 parameters are back to the old track classification values (by comparing step3 in wf 136.788 between this PR setup and the baseline after applying RecoTracker/IterativeTracking/customise_MVAPhase1_cfi.customise_MVAPhase1).

fabiocos · 2019-03-27T21:30:40Z

+1

@hajohajo @slava77 thanks for converging on this important move

cmsbuild · 2019-03-27T21:31:12Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

slava77 · 2019-03-28T13:25:09Z

@fabiocos
do we need a backport to 105X?
I'm not sure it's really needed.

fabiocos · 2019-03-28T15:59:12Z

@slava77 it is a good point, as 10_5_X is needed for the production for calibration, I assume we would like to do it without DNN classification at this point, but the customisation might be used. I let @franzoni @srimanob @prebello @zhenhu @pgunnell to comment

mtosi · 2019-04-17T10:29:19Z

ciao
@slava77 @fabiocos @franzoni @srimanob @prebello @zhenhu @pgunnell @hajohajo

I think I missed the backport of this PR in 10_5_X
is it needed ?
thanks

fabiocos · 2019-04-17T11:18:52Z

@mtosi unless we plan to have a new round of production, not in the plan so far to my knowledge, I would say no...

mtosi · 2019-04-17T12:00:43Z

@fabiocos thanks

mtosi · 2019-04-17T12:01:23Z

@mmusich do you know the customization to use ?

mmusich · 2019-04-17T12:03:40Z

@mmusich do you know the customization to use ?

yep: customise : RecoTracker/IterativeTracking/customise_MVAPhase1_cfi.customise_MVAPhase1

mmusich · 2019-04-17T12:17:45Z

@fabiocos

@mtosi unless we plan to have a new round of production, not in the plan so far to my knowledge, I would say no...

it's a bit unfortunate that this decision not to backport was taken or maybe overlooked (?), there is actually a need for massive customizations for the production of samples for the misalignment scenarios for ultra-legacy, but OK apparently PdmV has taken care of it centrally.

fabiocos · 2019-04-17T12:36:13Z

@mmusich I repeat: do we have a use case now, more samples that would benefit from this and require extra work if this backport is not done? As I have said, unless we have a practical use case, I consider 10_5_X as a pre-release used for larger than RelVal productions.

mmusich · 2019-04-17T12:42:26Z

more samples that would benefit from this and require extra work if this backport is not done?

I think the DR of the samples that actually do care about tracking in 10.5.0 is not started yet so in principle a release making use of such a backport could be used, but as I said the customization work to undo this has apparently been already carried out by PdmV centrally into the McM configuration (which makes it ugly, but correct)

fabiocos · 2019-04-17T12:45:56Z

@prebello @zhenhu @pgunnell please see the discussion above, possible comments are welcome

cmsbuild added this to the CMSSW_10_6_X milestone Mar 16, 2019

cmsbuild added code-checks-pending comparison-pending operations-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 16, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 16, 2019

cmsbuild added tests-started and removed tests-pending labels Mar 16, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Mar 16, 2019

slava77 reviewed Mar 16, 2019

View reviewed changes

cmsbuild added code-checks-pending comparison-pending tests-pending and removed code-checks-approved comparison-notrun tests-rejected labels Mar 16, 2019

cmsbuild added tests-approved and removed tests-started labels Mar 27, 2019

cmsbuild added comparison-available and removed comparison-pending labels Mar 27, 2019

slava77 reviewed Mar 27, 2019

View reviewed changes

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 27, 2019

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending orp-pending pending-signatures labels Mar 27, 2019

cmsbuild merged commit 90f85a3 into cms-sw:master Mar 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert default tracking classifier back to BDT for Phase1 (set in PR21717) #26199

Revert default tracking classifier back to BDT for Phase1 (set in PR21717) #26199

hajohajo commented Mar 16, 2019

cmsbuild commented Mar 16, 2019

cmsbuild commented Mar 16, 2019

cmsbuild commented Mar 16, 2019

perrotta commented Mar 16, 2019

cmsbuild commented Mar 16, 2019 •

edited

cmsbuild commented Mar 16, 2019

cmsbuild commented Mar 16, 2019

slava77 Mar 16, 2019

hajohajo Mar 16, 2019

cmsbuild commented Mar 27, 2019

cmsbuild commented Mar 27, 2019

slava77 left a comment

slava77 Mar 27, 2019

slava77 Mar 27, 2019

slava77 commented Mar 27, 2019 •

edited

fabiocos commented Mar 27, 2019

cmsbuild commented Mar 27, 2019

slava77 commented Mar 28, 2019

fabiocos commented Mar 28, 2019

mtosi commented Apr 17, 2019

fabiocos commented Apr 17, 2019

mtosi commented Apr 17, 2019

mtosi commented Apr 17, 2019

mmusich commented Apr 17, 2019

mmusich commented Apr 17, 2019 •

edited

fabiocos commented Apr 17, 2019

mmusich commented Apr 17, 2019

fabiocos commented Apr 17, 2019

Revert default tracking classifier back to BDT for Phase1 (set in PR21717) #26199

Revert default tracking classifier back to BDT for Phase1 (set in PR21717) #26199

Conversation

hajohajo commented Mar 16, 2019

cmsbuild commented Mar 16, 2019

cmsbuild commented Mar 16, 2019

cmsbuild commented Mar 16, 2019

perrotta commented Mar 16, 2019

cmsbuild commented Mar 16, 2019 • edited

cmsbuild commented Mar 16, 2019

cmsbuild commented Mar 16, 2019

slava77 Mar 16, 2019

Choose a reason for hiding this comment

hajohajo Mar 16, 2019

Choose a reason for hiding this comment

cmsbuild commented Mar 27, 2019

cmsbuild commented Mar 27, 2019

slava77 left a comment

Choose a reason for hiding this comment

slava77 Mar 27, 2019

Choose a reason for hiding this comment

slava77 Mar 27, 2019

Choose a reason for hiding this comment

slava77 commented Mar 27, 2019 • edited

fabiocos commented Mar 27, 2019

cmsbuild commented Mar 27, 2019

slava77 commented Mar 28, 2019

fabiocos commented Mar 28, 2019

mtosi commented Apr 17, 2019

fabiocos commented Apr 17, 2019

mtosi commented Apr 17, 2019

mtosi commented Apr 17, 2019

mmusich commented Apr 17, 2019

mmusich commented Apr 17, 2019 • edited

fabiocos commented Apr 17, 2019

mmusich commented Apr 17, 2019

fabiocos commented Apr 17, 2019

cmsbuild commented Mar 16, 2019 •

edited

slava77 commented Mar 27, 2019 •

edited

mmusich commented Apr 17, 2019 •

edited