pr106x Fix bug memory over-read in OMTF Producer

[rekovic]

10_6_X

This PR is a fix for the problem of memory over-read in the OMTF Producer, mentioned in the issue #25785

[cmsbuild]

The code-checks are being triggered in jenkins.

[rekovic]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26208/8815

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33644/console Started: 2019/03/18 17:00

[cmsbuild]

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1TMuonOverlap

@cmsbuild, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

@rekovic thanks, this looks the minimal protection we discussed earlier today. Do I understand correctly that a deeper check is needed by the experts, so as to fully understand the cause of this issue and the possible impact of the protection? Just to keep track of the problem for the future

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33649/console Started: 2019/03/19 00:28

[rekovic]

hi @fabiocos
Yes. That is correct.

The OMTF experts @kbunkow, @konec.
Please take a look at this fix. It should protect from illegal memory access. If you need additional changes, please make an additional PR on top of this, but this fix should go "as is" to allow for further central effort of the code clean-up.

[cmsbuild]

+1
Tested at: 4cad6af
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26208/33649/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26208/33649/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114631
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@Dr15Jones FYI, this is meant to address #25785

[fabiocos]

+1