Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect FlexiLoader against no HE #2624

Merged
merged 1 commit into from Feb 25, 2014

Conversation

bsunanda
Copy link
Contributor

Protect HcalFlexiGeometryLoader

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Protect FlexiLoader against no HE

It involves the following packages:

Geometry/HcalCommonData
Geometry/HcalTowerAlgo

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Feb 25, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

merge

Tested with #2627. See the notes there.

cmsbuild added a commit that referenced this pull request Feb 25, 2014
Protect FlexiLoader against no HE
@cmsbuild cmsbuild merged commit 9ee955e into cms-sw:CMSSW_6_2_X_SLHC Feb 25, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Update data-L1Trigger-L1TCalorimeter.spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants