New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PPS] Track time selector for miniAOD lite format #26247
Conversation
… to be tuned after time calibration PR is merged
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26247/8897
|
A new Pull Request was created by @forthommel (Laurent Forthomme) for master. It involves the following packages: RecoCTPPS/TotemRPLocal @cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
please elaborate what was actually tested.
|
@slava77 The test was rather trivial, as the timing information is not yet stored for diamond tracks (only up to the rechits level as it is), only to be included with the forthcoming PR right after #26207 is merged. |
Comparison job queued. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26247/9015
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PPS timing detectors tracks time is now stored regardless the 25 ns time slice it was reconstructed in. Furthermore a skimming procedure is introduced for these tracks at the lite tracks format level. It allows to define a window in (absolute) time for
CTPPSDiamondLocalTrack
to be recasted to lite tracks format.PR validation:
Passed lite conversion test for arbitrary 2017 and 2018 AOD-level EDM files with diamond detectors' pots inserted.
runTheMatrix
tests still ongoing.if this PR is a backport please specify the original PR: N/A
Before submitting your pull requests, make sure you followed this checklist: