Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPS] Track time selector for miniAOD lite format #26247

Merged
merged 11 commits into from Apr 3, 2019

Conversation

forthommel
Copy link
Contributor

PR description:

PPS timing detectors tracks time is now stored regardless the 25 ns time slice it was reconstructed in. Furthermore a skimming procedure is introduced for these tracks at the lite tracks format level. It allows to define a window in (absolute) time for CTPPSDiamondLocalTrack to be recasted to lite tracks format.

PR validation:

Passed lite conversion test for arbitrary 2017 and 2018 AOD-level EDM files with diamond detectors' pots inserted.
runTheMatrix tests still ongoing.

if this PR is a backport please specify the original PR: N/A

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26247/8897

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

RecoCTPPS/TotemRPLocal

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@jan-kaspar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Mar 25, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 25, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33757/console Started: 2019/03/25 21:02

@slava77
Copy link
Contributor

slava77 commented Mar 25, 2019

PR validation:

Passed lite conversion test for arbitrary 2017 and 2018 AOD-level EDM files with diamond detectors' pots inserted.

please elaborate what was actually tested.
It looks like we expect some changes in the outputs of the code modified in this PR.

  • which distributions are expected to change?

@forthommel
Copy link
Contributor Author

forthommel commented Mar 25, 2019

@slava77 The test was rather trivial, as the timing information is not yet stored for diamond tracks (only up to the rechits level as it is), only to be included with the forthcoming PR right after #26207 is merged.
Hence the sanity check only ensures nothing is crashing in the standard workflow, for several periods.
To summarise, no changes in the lite tracks collection are expected with this PR (tracks time=0 right now, « loosest as possible » selection before further tuning).

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26247/9015

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2019

Pull request #26247 was updated. @cmsbuild, @perrotta, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Apr 2, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33895/console Started: 2019/04/02 10:29

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26247/33895/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 2, 2019

+1

for #26247 38b0adf

  • code changes are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no differences as expected for the "catch-all" defaults of the newly added selections

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 3, 2019

+1

@cmsbuild cmsbuild merged commit 1662d47 into cms-sw:master Apr 3, 2019
@forthommel forthommel deleted the ppsLiteTracks_OOTselector branch July 15, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants