HBHE: Mahi arrival time

[mariadalfonso]

This PR fix a few bugs found in the computation of the arrival time
(as follow up of #25526)

See more description for the mahi-arrival time here
https://indico.cern.ch/event/803700/contributions/3347234/attachments/1808485/2952580/PSG_0308.pdf

Also a configurable has been added to switch off the computation of the pulse arrival time.
The arrival time is not used at HLT and it use 10% of the cpu, cpu time that can be saved for Run3.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26270/8948

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @mariadalfonso for master.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33803/console Started: 2019/03/27 16:59

[cmsbuild]

+1
Tested at: bc65d12
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26270/33803/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26270/33803/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 267 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 961
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3113671
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #26270 bc65d12

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show differences in HCAL time variables and what's derived from them

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1