Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit HBHE MAHI algorithm hit time #25526

Closed
slava77 opened this issue Dec 20, 2018 · 5 comments
Closed

revisit HBHE MAHI algorithm hit time #25526

slava77 opened this issue Dec 20, 2018 · 5 comments

Comments

@slava77
Copy link
Contributor

slava77 commented Dec 20, 2018

this is a follow up to #25469

As a part of review of that PR it was uncovered that the hit time was artificially restricted to be around zero due to some incorrect estimate of the pulse shape derivative.
After fixing the issue the hit time distribution is back to be very weakly constrained and perhaps a better logic is needed to compute it.

@jaylawhorn @jaehyeok @mariadalfonso @deguio

@cmsbuild
Copy link
Contributor

A new Issue was created by @slava77 Slava Krutelyov.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Dec 20, 2018

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor Author

slava77 commented May 24, 2019

+1

this is supposedly closed by #26270

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants