New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revisit HBHE MAHI algorithm hit time #25526
Comments
A new Issue was created by @slava77 Slava Krutelyov. @davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign reconstruction |
cmsbuild
added
pending-signatures
reconstruction-pending
and removed
pending-assignment
labels
Dec 20, 2018
+1 this is supposedly closed by #26270 |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
May 24, 2019
This issue is fully signed and ready to be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
this is a follow up to #25469
As a part of review of that PR it was uncovered that the hit time was artificially restricted to be around zero due to some incorrect estimate of the pulse shape derivative.
After fixing the issue the hit time distribution is back to be very weakly constrained and perhaps a better logic is needed to compute it.
@jaylawhorn @jaehyeok @mariadalfonso @deguio
The text was updated successfully, but these errors were encountered: