Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the RecoTau validation discriminators #2629

Merged

Conversation

jpavel
Copy link
Contributor

@jpavel jpavel commented Feb 25, 2014

Forward port of #2492. Contains changes in the histogram range, binning and content to reflect changes in the tau ID algorithm. Merges cleanly with #2449

@jpavel jpavel restored the 71x-Validation-RecoTau-histogramUpdate branch February 25, 2014 10:46
@jpavel jpavel mentioned this pull request Feb 25, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_1_X.

Update of the RecoTau validation discriminators

It involves the following packages:

Validation/RecoTau

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Feb 25, 2014

@jpavel
this adds a lot of histograms. are them all needed? could some of the old histos be removed? are all of them going to be inspected during the validation?

thanks for clarifying,
F.

@jpavel
Copy link
Contributor Author

jpavel commented Feb 25, 2014

All these histograms are at the moment made by hand by tau POG validators who inspect them. Having them in the release would save them some work. @lperrini can comment if I understood wrong. Regarding the removal of old ones, there are three discriminators which are going to be deprecated soon, but not now. At the moment, all the discriminant are recommended, but we can probably remove some working points if amount of histograms is an issue.

@deguio
Copy link
Contributor

deguio commented Feb 25, 2014

+1
@jpavel the amount of histograms is always an issue ;)
it would be great if you can remove the discriminants as soon as they are deprecated. please don't forget about it.

thanks,
F.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 25, 2014
…Update

DQM -- Update of the RecoTau validation discriminators
@ktf ktf merged commit 23c19b2 into cms-sw:CMSSW_7_1_X Feb 25, 2014
@jpavel jpavel deleted the 71x-Validation-RecoTau-histogramUpdate branch February 26, 2014 09:34
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants