Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx189 Add specifics for HGCal V10 geometry #26301

Merged
merged 2 commits into from Apr 5, 2019

Conversation

bsunanda
Copy link
Contributor

PR description:

Introduce HGCal V10 geometry specific Era which will introduce things specific to C8 calorimeter design

PR validation:

Not yet tested - with this the V10 specific layer weights will be added and then tested with changed D41 scenario

if this PR is a backport please specify the original PR:

It is a new set of Era's and not a back porting

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26301/8995

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33861/console Started: 2019/03/30 00:30

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26301/33861/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3134059
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3133861
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

+operations

the update to Eras is coherent with the purpose of the PR, and parallel to what already done.
A possible reorganization of phase2 eras go beyond the scope of this PR (@kpedro88 FYI)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26301/33918/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 3, 2019

+upgrade

@fabiocos
Copy link
Contributor

fabiocos commented Apr 3, 2019

+operations

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 4, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2019

@prebello @zhenhu objections? Or can we move forward?

@prebello
Copy link
Contributor

prebello commented Apr 4, 2019

+1

no objections

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2019

+1

@cmsbuild cmsbuild merged commit c9a10d7 into cms-sw:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants