Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hadronizer for HToGG Minlo NNLOPS pLHE relval #26303

Merged
merged 1 commit into from Apr 5, 2019

Conversation

chayanit
Copy link

PR description:

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26303/9000

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @chayanit (Chayanit Asawatangtrakuldee) for master.

It involves the following packages:

Configuration/Generator

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@alberto-sanchez
Copy link
Member

@chayanit could you please elaborate, what is the purpose of this PR?. which relval?

@alberto-sanchez
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33893/console Started: 2019/04/02 03:24

@chayanit
Copy link
Author

chayanit commented Apr 2, 2019

Hi @alberto-sanchez , this is needed for new pLHE RelVal workflow we want to add to the main/standard campaign according to this JIRA https://its.cern.ch/jira/browse/PDMVRELVALS-27
Chayanit
@zhenhu @prebello @pgunnell

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26303/33893/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@efeyazgan
Copy link
Contributor

Is there a particular reason that this is using CUETP8M1 but not CP5?

@chayanit
Copy link
Author

chayanit commented Apr 5, 2019

Hi @efeyazgan, we discussed (me and @pgunnell) that as this relval is needed just to test the whole machinery and workflow in the new releases. The process is not so important and there will be no specific physics meaning (https://its.cern.ch/jira/browse/PDMVRELVALS-27). So we decided to keep the same tuning for all MC years. It would be nice if we can have this merge soon. Thanks.

@efeyazgan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2019

+1

@cmsbuild cmsbuild merged commit fa66905 into cms-sw:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants