Fix a corner case in ClusterTPAssociationProducer #26304
Conversation
Otherwise equal_range() will throw an exception if accessing the mapping with such a cluster as the ProductID of these (key) clusters has not been recorded.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26304/9002
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: SimTracker/TrackerHitAssociation @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: cc13f07 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step2_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
The failures are input file read errors (network failures), so let's try again after a short while. |
|
@cmsbuild, please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
…nterface changes from cms-sw#26304
Adapt ClusterTPAssociationHeterogeneous following the change of interface in ClusterTPAssociation introduced by cms-sw#26304.
PR description:
There is a rare case in ClusterTPAssociationProducer that if none of the pixel or strip clusters match to SimTracks, the
ClusterTPAssociation::equal_range()will throw an exception for such pixel or strip cluster as the ProductID of these (key) clusters has not been recorded. The behavior should have been to return an empty range.This PR changes the behavior such that the ProductIDs of the cluster collections are always added to the
ClusterTPAssociation.Thanks to @slava77 for reporting.
There should be no changes in standard workflows (as the exception has not been observed before).
PR validation:
@slava77 said that the problematic event got processed correctly.